comments

kubewatcher/kubewatcher.go

@@ -199,6 +199,10 @@ func (ws *watchSubscription) eventDispatchLoop(poster *Poster) {
 		if err != nil {
 			log.Println("Failed to serialize object: %v", err)
 		}
+		// TODO re: objtype -- mabye we should use runtime
+		// type info to get the obj type, in case the watch
+		// can send multiple types of objects (it probably
+		// sends a different type when ev.Type == ERROR?)
 		poster.Post(string(ev.Type), ws.Watch.ObjType, ws.Watch.Url, &buf)
 	}
 	if !atomic.LoadInt32(ws.stopped) {

kubewatcher/webhookposter.go

@@ -72,7 +72,7 @@ func (p *Poster) svc() {
 			if err == nil {
 				log.Printf("request error: %v", body)
 			}
-			// TODO retries etc.
+			// TODO retries, persistence, etc.
 		}
 		resp.Body.Close()
 	}