From 215f4fc30fb4795376357f2fe70870f2193d8ba1 Mon Sep 17 00:00:00 2001 From: Soam Vasani Date: Thu, 15 Dec 2016 19:48:45 -0800 Subject: [PATCH] comments --- kubewatcher/kubewatcher.go | 4 ++++ kubewatcher/webhookposter.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/kubewatcher/kubewatcher.go b/kubewatcher/kubewatcher.go index db403974..baf48d2e 100644 --- a/kubewatcher/kubewatcher.go +++ b/kubewatcher/kubewatcher.go @@ -199,6 +199,10 @@ func (ws *watchSubscription) eventDispatchLoop(poster *Poster) { if err != nil { log.Println("Failed to serialize object: %v", err) } + // TODO re: objtype -- mabye we should use runtime + // type info to get the obj type, in case the watch + // can send multiple types of objects (it probably + // sends a different type when ev.Type == ERROR?) poster.Post(string(ev.Type), ws.Watch.ObjType, ws.Watch.Url, &buf) } if !atomic.LoadInt32(ws.stopped) { diff --git a/kubewatcher/webhookposter.go b/kubewatcher/webhookposter.go index 95fe5246..e4a19e71 100644 --- a/kubewatcher/webhookposter.go +++ b/kubewatcher/webhookposter.go @@ -72,7 +72,7 @@ func (p *Poster) svc() { if err == nil { log.Printf("request error: %v", body) } - // TODO retries etc. + // TODO retries, persistence, etc. } resp.Body.Close() }