A newdeploy backend which uses new deployment to serve requests. This is the second phase of #193 and builds on top of changes in #384 . * Executor layer added on top of pool manager * Removed the external server for executor * Minor changes to keep existing semantics as much possible * Separating the executor vs. poolmgr backend functionality and associated data members * Executor logic separated from Poolmgr backend completely, placeholder for new backend * Changed references to poolmgr in tests * Moved poolmgr to it's package, as a side effect moved Cache to its's package (was causing cyclical dependency) and had to make some data structures exposed outside package * Rebased from master and changed references to tpr -> crd * Executor layer added on top of pool manager * Executor logic separated from Poolmgr backend completely, placeholder for new backend * Changed podName to a generic objectReference in fscache (#391) Changed podName to a generic objectReference in function service cache implementation. * Moved poolmgr to it's package, as a side effect moved Cache to its's package (was causing cyclical dependency) and had to make some data structures exposed outside package * Rebased from master and changed references to tpr -> crd * Merged from master with latest changes * Executor layer added on top of pool manager * Removed the external server for executor * Minor changes to keep existing semantics as much possible * Separating the executor vs. poolmgr backend functionality and associated data members * Executor logic separated from Poolmgr backend completely, placeholder for new backend * Changed references to poolmgr in tests * update compiling.md to use helm * Compile instructions: changed pullPolicy to IfNotPresent (#378) Containers will get stuck in ErrImagePull/ImagePullBackOff state otherwise * Moved poolmgr to it's package, as a side effect moved Cache to its's package (was causing cyclical dependency) and had to make some data structures exposed outside package * Fetcher called when pod is created for newDeploy backend but also supports older way, this is WIP and still needs pod specialization and creating & exposing a service so the URL can be hit by end user * WIP Specializing the POD as part of startup along with fetching * Working specialization of a new deployment. Needs some work on caching, cleanup etc. * Switched to service based address instead of POD address * Minor formating issue fixed * Added logging to pods and a readiness check, the readiness check is flaky though ATM * Fixed some rebase issues that were failing build * Better names for K8S objects and methods * Switched usage of FuncSvc in backends from pod to api.ObjectReference * Adding retry to fetcher request, for now just using default retry client which might need tweaking in future * Switching to plain old retry, some issue in getting retryablehttp with glide import * Removed stale executor service & deployment from previous merge * Addressed review comments, still testing some areas * Added types in FunctionSpec * Resolved conflicts due to merge from executor_abstraction branch * Added backend type on EnvironmentSpec along with operations for create/list/update, the pools are created/destroyed based on change in backend type * Backend from types and a minor err return issue fixed * Draft version of CPU and memory parameters added to environment * Added resourceReq to newDeploy, though it has some issues * Issue with resourceName fixed, now newdeploy pods also pick up resources from the environment config * Adding scale params, removing validation on CPU params for now * Fixed a formatting issue * Checking if slight more delay helps in the test which is currently failing for internal routes * The resourceList newly added in Env can not be compared by compiler, hence must use breakdown comparison instead * Added strategy selection on client side * Added caching, informers, delete operations for newdeploy backend functions * Deleted a stale directory * A simple HPA based on scale parameters, testing still WIP * Fixed a small issue in delete function, added HPA delete too when deleting a function * Previous merge missed the pkg flag for update fn command somehow, fixed that * Fixed comments from review * Changed poolmgr cleanup to be generic cleanup and moved to executor, added instanceID labels to newdeploy so that cleanup works * Moved instanceIdLabel to types to avoid cyclic dependency * More review fixes * Tweaking sleep to see results * If user does not provide poolsize, then it should not default to zero * Switched to naming convention for now, fixed default poolsize if not provided * Changed error return behaviour in delete fn, also changed cleanup to look based on obj type though support for additional type will need more work * Changed check location so avoid false logging * Test for newdeploy backend * Adding tests for poolmgr backend * Fixed an issue with glide dependency version, already fixed in master * Added instanceId for NewDeploy, Initial cleanup now cleans older objects of newdeploy backend, removed eagercreate flag and instead using minScale to drive eager creation * Moved cleanup to executor layer with cleanup for newDeploy backend, changes to use the new Cache impl * Cleaning up pod & rs along with deployment for newdeploy backend * Enhanced fn and env listing to show min/maxscale and resuorces respectively * Added conditional heapster deployment and fixed a small issue with resources for fetcher container in function pod * Addressed review comments from previous change * Addressed some more review comments - majorly create only on NotFoundError * Added TargetCPU as an input for scaling * Bumped target CPU to be greater than 0 and added a default value * Min replicas should be 1 even if the minScale is 0 when creating deployment * Changed name from 'backend' to executorType, added additional test for minscale 0 case, changed TargetCPU to TargetCPUPercent
359 lines
9.8 KiB
Go
359 lines
9.8 KiB
Go
/*
|
|
Copyright 2016 The Fission Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"log"
|
|
"net/http"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/pkg/api/v1"
|
|
|
|
"github.com/fission/fission"
|
|
"github.com/fission/fission/controller/client"
|
|
"github.com/fission/fission/crd"
|
|
)
|
|
|
|
var g struct {
|
|
client *client.Client
|
|
}
|
|
|
|
func panicIf(err error) {
|
|
if err != nil {
|
|
log.Panicf("err: %v", err)
|
|
}
|
|
}
|
|
|
|
func assert(c bool, msg string) {
|
|
if !c {
|
|
log.Fatalf("assert failed: %v", msg)
|
|
}
|
|
}
|
|
|
|
func assertNameReuseFailure(err error, name string) {
|
|
assert(err != nil, "recreating "+name+" with same name must fail")
|
|
fe, ok := err.(fission.Error)
|
|
assert(ok, "error must be a fission Error")
|
|
assert(fe.Code == fission.ErrorNameExists, "error must be a name exists error")
|
|
}
|
|
|
|
func assertNotFoundFailure(err error, name string) {
|
|
assert(err != nil, "requesting a non-existent "+name+" must fail")
|
|
fe, ok := err.(fission.Error)
|
|
assert(ok, "error must be a fission Error")
|
|
if fe.Code != fission.ErrorNotFound {
|
|
log.Fatalf("error must be a not found error: %v", fe)
|
|
}
|
|
}
|
|
|
|
func assertCronSpecFails(err error) {
|
|
assert(err != nil, "using an invalid cron spec must fail")
|
|
fe, ok := err.(fission.Error)
|
|
assert(ok, "error must be a fission Error")
|
|
assert(fe.Code == fission.ErrorInvalidArgument, "error must be a invalid argument error")
|
|
}
|
|
|
|
func TestFunctionApi(t *testing.T) {
|
|
testFunc := &crd.Function{
|
|
Metadata: metav1.ObjectMeta{
|
|
Name: "foo",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: fission.FunctionSpec{
|
|
Environment: fission.EnvironmentReference{
|
|
Name: "nodejs",
|
|
},
|
|
Package: fission.FunctionPackageRef{
|
|
FunctionName: "xxx",
|
|
},
|
|
},
|
|
}
|
|
_, err := g.client.FunctionGet(&metav1.ObjectMeta{
|
|
Name: testFunc.Metadata.Name,
|
|
Namespace: metav1.NamespaceDefault,
|
|
})
|
|
assertNotFoundFailure(err, "function")
|
|
|
|
m, err := g.client.FunctionCreate(testFunc)
|
|
panicIf(err)
|
|
defer func() {
|
|
err := g.client.FunctionDelete(m)
|
|
panicIf(err)
|
|
}()
|
|
|
|
_, err = g.client.FunctionCreate(testFunc)
|
|
assertNameReuseFailure(err, "function")
|
|
|
|
testFunc.Metadata.ResourceVersion = m.ResourceVersion
|
|
testFunc.Spec.Package.FunctionName = "yyy"
|
|
_, err = g.client.FunctionUpdate(testFunc)
|
|
panicIf(err)
|
|
|
|
testFunc.Metadata.ResourceVersion = ""
|
|
testFunc.Metadata.Name = "bar"
|
|
m2, err := g.client.FunctionCreate(testFunc)
|
|
panicIf(err)
|
|
defer g.client.FunctionDelete(m2)
|
|
|
|
funcs, err := g.client.FunctionList()
|
|
panicIf(err)
|
|
assert(len(funcs) == 2, fmt.Sprintf("created two functions, but found %v", len(funcs)))
|
|
|
|
funcs_url := g.client.Url + "/v2/functions"
|
|
resp, err := http.Get(funcs_url)
|
|
panicIf(err)
|
|
defer resp.Body.Close()
|
|
assert(resp.StatusCode == 200, "http get status code on /v1/functions")
|
|
|
|
var found bool = false
|
|
for _, b := range resp.Header["Content-Type"] {
|
|
if b == "application/json; charset=utf-8" {
|
|
found = true
|
|
}
|
|
}
|
|
assert(found, "incorrect response content type")
|
|
}
|
|
|
|
func TestHTTPTriggerApi(t *testing.T) {
|
|
testTrigger := &crd.HTTPTrigger{
|
|
Metadata: metav1.ObjectMeta{
|
|
Name: "foo",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: fission.HTTPTriggerSpec{
|
|
RelativeURL: "/hello",
|
|
FunctionReference: fission.FunctionReference{
|
|
Type: fission.FunctionReferenceTypeFunctionName,
|
|
Name: "foo",
|
|
},
|
|
},
|
|
}
|
|
_, err := g.client.HTTPTriggerGet(&metav1.ObjectMeta{
|
|
Name: testTrigger.Metadata.Name,
|
|
Namespace: metav1.NamespaceDefault,
|
|
})
|
|
assertNotFoundFailure(err, "httptrigger")
|
|
|
|
m, err := g.client.HTTPTriggerCreate(testTrigger)
|
|
panicIf(err)
|
|
defer g.client.HTTPTriggerDelete(m)
|
|
|
|
_, err = g.client.HTTPTriggerCreate(testTrigger)
|
|
assertNameReuseFailure(err, "httptrigger")
|
|
|
|
tr, err := g.client.HTTPTriggerGet(m)
|
|
panicIf(err)
|
|
assert(testTrigger.Spec == tr.Spec, "trigger should match after reading")
|
|
|
|
testTrigger.Metadata.ResourceVersion = m.ResourceVersion
|
|
testTrigger.Spec.RelativeURL = "/hi"
|
|
_, err = g.client.HTTPTriggerUpdate(testTrigger)
|
|
panicIf(err)
|
|
|
|
testTrigger.Metadata.ResourceVersion = ""
|
|
testTrigger.Metadata.Name = "yyy"
|
|
_, err = g.client.HTTPTriggerCreate(testTrigger)
|
|
assert(err != nil, "duplicate trigger should not be allowed")
|
|
|
|
testTrigger.Spec.RelativeURL = "/hi2"
|
|
m2, err := g.client.HTTPTriggerCreate(testTrigger)
|
|
panicIf(err)
|
|
defer g.client.HTTPTriggerDelete(m2)
|
|
|
|
ts, err := g.client.HTTPTriggerList()
|
|
panicIf(err)
|
|
assert(len(ts) == 2, fmt.Sprintf("created two triggers, but found %v", len(ts)))
|
|
}
|
|
|
|
func TestEnvironmentApi(t *testing.T) {
|
|
|
|
testEnv := &crd.Environment{
|
|
Metadata: metav1.ObjectMeta{
|
|
Name: "foo",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: fission.EnvironmentSpec{
|
|
Runtime: fission.Runtime{
|
|
Image: "gcr.io/xyz",
|
|
},
|
|
Resources: v1.ResourceRequirements{},
|
|
},
|
|
}
|
|
_, err := g.client.EnvironmentGet(&metav1.ObjectMeta{
|
|
Name: testEnv.Metadata.Name,
|
|
Namespace: metav1.NamespaceDefault,
|
|
})
|
|
assertNotFoundFailure(err, "environment")
|
|
|
|
m, err := g.client.EnvironmentCreate(testEnv)
|
|
panicIf(err)
|
|
defer g.client.EnvironmentDelete(m)
|
|
|
|
_, err = g.client.EnvironmentCreate(testEnv)
|
|
assertNameReuseFailure(err, "environment")
|
|
|
|
e, err := g.client.EnvironmentGet(m)
|
|
panicIf(err)
|
|
assert(testEnv.Spec.AllowedFunctionsPerContainer == e.Spec.AllowedFunctionsPerContainer, "env AllowedFunctionsPerContainer should match after reading")
|
|
assert(testEnv.Spec.Poolsize == e.Spec.Poolsize, "env Poolsize should match after reading")
|
|
assert(testEnv.Spec.Builder == e.Spec.Builder, "env Builder should match after reading")
|
|
assert(testEnv.Spec.Runtime == e.Spec.Runtime, "env Runtime should match after reading")
|
|
assert(testEnv.Spec.Version == e.Spec.Version, "env Version should match after reading")
|
|
|
|
testEnv.Metadata.ResourceVersion = m.ResourceVersion
|
|
testEnv.Spec.Runtime.Image = "another-img"
|
|
_, err = g.client.EnvironmentUpdate(testEnv)
|
|
panicIf(err)
|
|
|
|
testEnv.Metadata.ResourceVersion = ""
|
|
testEnv.Metadata.Name = "bar"
|
|
m2, err := g.client.EnvironmentCreate(testEnv)
|
|
panicIf(err)
|
|
defer g.client.EnvironmentDelete(m2)
|
|
|
|
ts, err := g.client.EnvironmentList()
|
|
panicIf(err)
|
|
assert(len(ts) == 2, fmt.Sprintf("created two envs, but found %v", len(ts)))
|
|
}
|
|
|
|
func TestWatchApi(t *testing.T) {
|
|
testWatch := &crd.KubernetesWatchTrigger{
|
|
Metadata: metav1.ObjectMeta{
|
|
Name: "xxx",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: fission.KubernetesWatchTriggerSpec{
|
|
Namespace: "default",
|
|
Type: "pod",
|
|
FunctionReference: fission.FunctionReference{
|
|
Type: fission.FunctionReferenceTypeFunctionName,
|
|
Name: "foo",
|
|
},
|
|
},
|
|
}
|
|
_, err := g.client.WatchGet(&metav1.ObjectMeta{
|
|
Name: testWatch.Metadata.Name,
|
|
Namespace: metav1.NamespaceDefault,
|
|
})
|
|
assertNotFoundFailure(err, "watch")
|
|
|
|
m, err := g.client.WatchCreate(testWatch)
|
|
panicIf(err)
|
|
defer g.client.WatchDelete(m)
|
|
|
|
_, err = g.client.WatchCreate(testWatch)
|
|
assertNameReuseFailure(err, "watch")
|
|
|
|
w, err := g.client.WatchGet(m)
|
|
panicIf(err)
|
|
assert((testWatch.Spec.Namespace == w.Spec.Namespace &&
|
|
testWatch.Spec.Type == w.Spec.Type &&
|
|
testWatch.Spec.FunctionReference == w.Spec.FunctionReference), "watch should match after reading")
|
|
|
|
testWatch.Metadata.Name = "yyy"
|
|
m2, err := g.client.WatchCreate(testWatch)
|
|
panicIf(err)
|
|
defer g.client.WatchDelete(m2)
|
|
|
|
ws, err := g.client.WatchList()
|
|
panicIf(err)
|
|
assert(len(ws) == 2, fmt.Sprintf("created two watches, but found %v", len(ws)))
|
|
}
|
|
|
|
func TestTimeTriggerApi(t *testing.T) {
|
|
testTrigger := &crd.TimeTrigger{
|
|
Metadata: metav1.ObjectMeta{
|
|
Name: "xxx",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Spec: fission.TimeTriggerSpec{
|
|
Cron: "0 30 * * * *",
|
|
FunctionReference: fission.FunctionReference{
|
|
Type: fission.FunctionReferenceTypeFunctionName,
|
|
Name: "asdf",
|
|
},
|
|
},
|
|
}
|
|
_, err := g.client.TimeTriggerGet(&metav1.ObjectMeta{Name: testTrigger.Metadata.Name})
|
|
assertNotFoundFailure(err, "trigger")
|
|
|
|
m, err := g.client.TimeTriggerCreate(testTrigger)
|
|
panicIf(err)
|
|
defer g.client.TimeTriggerDelete(m)
|
|
|
|
_, err = g.client.TimeTriggerCreate(testTrigger)
|
|
assertNameReuseFailure(err, "trigger")
|
|
|
|
tr, err := g.client.TimeTriggerGet(m)
|
|
panicIf(err)
|
|
assert(testTrigger.Spec == tr.Spec, "trigger should match after reading")
|
|
|
|
testTrigger.Metadata.ResourceVersion = m.ResourceVersion
|
|
testTrigger.Spec.Cron = "@hourly"
|
|
_, err = g.client.TimeTriggerUpdate(testTrigger)
|
|
panicIf(err)
|
|
|
|
testTrigger.Metadata.ResourceVersion = ""
|
|
testTrigger.Metadata.Name = "yyy"
|
|
testTrigger.Spec.Cron = "Not valid cron spec"
|
|
_, err = g.client.TimeTriggerCreate(testTrigger)
|
|
assertCronSpecFails(err)
|
|
|
|
ts, err := g.client.TimeTriggerList()
|
|
panicIf(err)
|
|
assert(len(ts) == 1, fmt.Sprintf("created two time triggers, but found %v", len(ts)))
|
|
}
|
|
|
|
func TestMain(m *testing.M) {
|
|
flag.Parse()
|
|
|
|
// skip test if no cluster available for testing
|
|
kubeconfig := os.Getenv("KUBECONFIG")
|
|
if len(kubeconfig) == 0 {
|
|
log.Println("Skipping test, no kubernetes cluster")
|
|
return
|
|
}
|
|
|
|
go Start(8888)
|
|
|
|
time.Sleep(5 * time.Second)
|
|
g.client = client.MakeClient("http://localhost:8888")
|
|
|
|
resp, err := http.Get("http://localhost:8888/")
|
|
panicIf(err)
|
|
assert(resp.StatusCode == 200, "http get status code on root")
|
|
|
|
var found bool = false
|
|
for _, b := range resp.Header["Content-Type"] {
|
|
if b == "application/json; charset=utf-8" {
|
|
found = true
|
|
}
|
|
}
|
|
assert(found, "incorrect response content type")
|
|
|
|
_, err = ioutil.ReadAll(resp.Body)
|
|
panicIf(err)
|
|
|
|
os.Exit(m.Run())
|
|
}
|