Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mprove warning/verbose messages around namespace in Fission CLI (#2572)

Browse Source 
Removed extra warning message while creating HTTP trigger, and updated some verbose logs to show info related to the namespace.
This commit is contained in:
neha_gupta
2022-10-17 17:52:34 +05:30
committed by GitHub
parent 8d65b062f1
commit facd14de90
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/fission-cli/cmd/environment/delete.go
+1 -1
View File
@@ -43,7 +43,7 @@ func (opts *DeleteSubCommand) do(input cli.Input) (err error) {
if err != nil { if err != nil {
return errors.Wrap(err, "error creating environment") return errors.Wrap(err, "error creating environment")
} }
console.Verbose(2, "Namespace used to delete resource: %s ", currentContextNS) console.Verbose(2, "Searching for resource in %s Namespace", currentContextNS)
m := &metav1.ObjectMeta{ m := &metav1.ObjectMeta{
Name: input.String(flagkey.EnvName), Name: input.String(flagkey.EnvName),
pkg/fission-cli/cmd/httptrigger/create.go
-2
View File
@@ -126,8 +126,6 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
Namespace: userProvidedNS, Namespace: userProvidedNS,
} }
console.Warn(fmt.Sprintf("Ns: %v", userProvidedNS))
// For Specs, the spec validate checks for function reference // For Specs, the spec validate checks for function reference
if input.Bool(flagkey.SpecSave) { if input.Bool(flagkey.SpecSave) {
pkg/fission-cli/util/util.go
+2 -2
View File
@@ -494,9 +494,9 @@ func GetResourceNamespace(input cli.Input, deprecatedFlag string) (namespace, cu
if input.String(flagkey.Namespace) != "" { if input.String(flagkey.Namespace) != "" {
namespace = input.String(flagkey.Namespace) namespace = input.String(flagkey.Namespace)
currentNS = namespace currentNS = namespace
console.Verbose(2, "Namespace for resource %s ", currentNS)
return namespace, currentNS, err return namespace, currentNS, err
} }
console.Verbose(2, "Namespace from user %s ", namespace)
if namespace == "" { if namespace == "" {
if os.Getenv("FISSION_DEFAULT_NAMESPACE") != "" { if os.Getenv("FISSION_DEFAULT_NAMESPACE") != "" {
@@ -513,7 +513,7 @@ func GetResourceNamespace(input cli.Input, deprecatedFlag string) (namespace, cu
} }
} }
console.Verbose(2, "Namespace final %s ", currentNS) console.Verbose(2, "Namespace for resource %s ", currentNS)
return namespace, currentNS, nil return namespace, currentNS, nil
} }