From facd14de90c4ec33f7ee7cc0c320654bc5c875d3 Mon Sep 17 00:00:00 2001 From: neha_gupta Date: Mon, 17 Oct 2022 17:52:34 +0530 Subject: [PATCH] mprove warning/verbose messages around namespace in Fission CLI (#2572) Removed extra warning message while creating HTTP trigger, and updated some verbose logs to show info related to the namespace. --- pkg/fission-cli/cmd/environment/delete.go | 2 +- pkg/fission-cli/cmd/httptrigger/create.go | 2 -- pkg/fission-cli/util/util.go | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/fission-cli/cmd/environment/delete.go b/pkg/fission-cli/cmd/environment/delete.go index fcb0647c..3b86858e 100644 --- a/pkg/fission-cli/cmd/environment/delete.go +++ b/pkg/fission-cli/cmd/environment/delete.go @@ -43,7 +43,7 @@ func (opts *DeleteSubCommand) do(input cli.Input) (err error) { if err != nil { return errors.Wrap(err, "error creating environment") } - console.Verbose(2, "Namespace used to delete resource: %s ", currentContextNS) + console.Verbose(2, "Searching for resource in %s Namespace", currentContextNS) m := &metav1.ObjectMeta{ Name: input.String(flagkey.EnvName), diff --git a/pkg/fission-cli/cmd/httptrigger/create.go b/pkg/fission-cli/cmd/httptrigger/create.go index 4e219870..77e42935 100644 --- a/pkg/fission-cli/cmd/httptrigger/create.go +++ b/pkg/fission-cli/cmd/httptrigger/create.go @@ -126,8 +126,6 @@ func (opts *CreateSubCommand) complete(input cli.Input) error { Namespace: userProvidedNS, } - console.Warn(fmt.Sprintf("Ns: %v", userProvidedNS)) - // For Specs, the spec validate checks for function reference if input.Bool(flagkey.SpecSave) { diff --git a/pkg/fission-cli/util/util.go b/pkg/fission-cli/util/util.go index fbd9c55e..01c1e91f 100644 --- a/pkg/fission-cli/util/util.go +++ b/pkg/fission-cli/util/util.go @@ -494,9 +494,9 @@ func GetResourceNamespace(input cli.Input, deprecatedFlag string) (namespace, cu if input.String(flagkey.Namespace) != "" { namespace = input.String(flagkey.Namespace) currentNS = namespace + console.Verbose(2, "Namespace for resource %s ", currentNS) return namespace, currentNS, err } - console.Verbose(2, "Namespace from user %s ", namespace) if namespace == "" { if os.Getenv("FISSION_DEFAULT_NAMESPACE") != "" { @@ -513,7 +513,7 @@ func GetResourceNamespace(input cli.Input, deprecatedFlag string) (namespace, cu } } - console.Verbose(2, "Namespace final %s ", currentNS) + console.Verbose(2, "Namespace for resource %s ", currentNS) return namespace, currentNS, nil }