Fix CLI exits with status 0 when error occurs (#1393)

cmd/fission-cli/main.go

@@ -17,9 +17,15 @@ limitations under the License.
 package main
 
 import (
+	"os"
+
 	"github.com/fission/fission/cmd/fission-cli/app"
 )
 
 func main() {
-	app.App().Execute()
+	err := app.App().Execute()
+	if err != nil {
+		// let program exit with non-zero code when error occurs
+		os.Exit(1)
+	}
 }

pkg/fission-cli/cmd/function/command.go

@@ -70,7 +70,7 @@ func Commands() *cobra.Command {
 	wrapper.SetFlags(updateCmd, flag.FlagSet{
 		Required: []flag.Flag{flag.FnName},
 		Optional: []flag.Flag{flag.NamespaceFunction, flag.NamespaceEnvironment, flag.SpecSave,
-			flag.FnCode, flag.PkgSrcArchive, flag.PkgDeployArchive,
+			flag.FnCode, flag.PkgSrcArchive, flag.PkgDeployArchive, flag.FnEnvName,
 			flag.FnKeepURL, flag.FnEntryPoint, flag.FnBuildCmd, flag.FnPkgName, flag.HtUrl,
 			flag.HtMethod, flag.RunTimeMinCPU, flag.RunTimeMaxCPU, flag.RunTimeMinMemory,
 			flag.RunTimeMaxMemory, flag.ReplicasMin, flag.ReplicasMax, flag.FnExecutorType,

test/tests/test_specs/test_spec_merge/test_spec_merge.sh

@@ -9,8 +9,8 @@ fn_nd=nodehellond
 
 cleanup() {
     echo "Cleaning up..."
-    popd
     fission spec destroy || true
+    popd
 }
 
 trap cleanup EXIT
@@ -35,4 +35,4 @@ hnp=$(kubectl -n $FUNCTION_NAMESPACE get deployment -l=environmentName=$env_p -o
 if [[ "${hnp}" == "foo-bar" ]]
     then
         echo "Hostname matches for poolmgr function, podspec test 2/2 passsed"
-    fi    
+    fi