Fix provider review findings

This commit is contained in:
“Naeel”
2026-08-31 20:19:31 +03:00
parent 75c868e0b5
commit 86871498a2
13 changed files with 327 additions and 141 deletions
+12 -3
View File
@@ -52,6 +52,7 @@ class CloudInstanceChecker:
# ⛔ LEGACY: deck-api ЗАКРЫВАЕТСЯ. Использовать lk-api-gateway.
BASE_URL = "https://lk-api-gateway.ngcloud.ru/api/v1/svc"
REQUEST_TIMEOUT = 30
def __init__(self, token: str):
"""
@@ -88,7 +89,11 @@ class CloudInstanceChecker:
"pageSize": "100"
}
response = self.session.get(f"{self.BASE_URL}/instances", params=params)
response = self.session.get(
f"{self.BASE_URL}/instances",
params=params,
timeout=self.REQUEST_TIMEOUT,
)
response.raise_for_status()
data = response.json()
@@ -120,7 +125,11 @@ class CloudInstanceChecker:
"fields": "instanceConfigDtCreated,instanceUid,displayName,descr,svc,state,operations,availableOperations,uptime,isDeleted,updaterLogin,updaterShortname,explainedStatus,man,dependencies,dependentInstances,svcExtendedName"
}
response = self.session.get(f"{self.BASE_URL}/instances/{instance_uid}", params=params)
response = self.session.get(
f"{self.BASE_URL}/instances/{instance_uid}",
params=params,
timeout=self.REQUEST_TIMEOUT,
)
response.raise_for_status()
return response.json().get("instance")
@@ -184,7 +193,7 @@ class CloudInstanceChecker:
operations = instance_data.get("operations", [])
if operations:
last_op = operations[-1]
if last_op.get("isSuccessful") == False:
if last_op.get("isSuccessful") is False:
return InstanceState.OPERATION_FAILED
return InstanceState.UNKNOWN