Fix provider review findings

scripts/check_cloud_instances.py

@@ -52,6 +52,7 @@ class CloudInstanceChecker:
     
     # ⛔ LEGACY: deck-api ЗАКРЫВАЕТСЯ. Использовать lk-api-gateway.
     BASE_URL = "https://lk-api-gateway.ngcloud.ru/api/v1/svc"
+    REQUEST_TIMEOUT = 30
     
     def __init__(self, token: str):
         """
@@ -88,7 +89,11 @@ class CloudInstanceChecker:
                 "pageSize": "100"
             }
             
-            response = self.session.get(f"{self.BASE_URL}/instances", params=params)
+            response = self.session.get(
+                f"{self.BASE_URL}/instances",
+                params=params,
+                timeout=self.REQUEST_TIMEOUT,
+            )
             response.raise_for_status()
             
             data = response.json()
@@ -120,7 +125,11 @@ class CloudInstanceChecker:
                 "fields": "instanceConfigDtCreated,instanceUid,displayName,descr,svc,state,operations,availableOperations,uptime,isDeleted,updaterLogin,updaterShortname,explainedStatus,man,dependencies,dependentInstances,svcExtendedName"
             }
             
-            response = self.session.get(f"{self.BASE_URL}/instances/{instance_uid}", params=params)
+            response = self.session.get(
+                f"{self.BASE_URL}/instances/{instance_uid}",
+                params=params,
+                timeout=self.REQUEST_TIMEOUT,
+            )
             response.raise_for_status()
             
             return response.json().get("instance")
@@ -184,7 +193,7 @@ class CloudInstanceChecker:
         operations = instance_data.get("operations", [])
         if operations:
             last_op = operations[-1]
-            if last_op.get("isSuccessful") == False:
+            if last_op.get("isSuccessful") is False:
                 return InstanceState.OPERATION_FAILED
         
         return InstanceState.UNKNOWN

scripts/s3_notification_example.sh

@@ -63,10 +63,18 @@ if [[ -z "$ACCESS_KEY" || -z "$SECRET_KEY" || -z "$HOST_BASE" ]]; then
 fi
 
 mc alias rm "$ALIAS_NAME" >/dev/null 2>&1 || true
-mc alias set "$ALIAS_NAME" "https://$HOST_BASE" "$ACCESS_KEY" "$SECRET_KEY" >/dev/null
+
+MC_CONFIG_DIR="$(mktemp -d)"
+cleanup() {
+  rm -rf "$MC_CONFIG_DIR"
+}
+trap cleanup EXIT
+
+export MC_HOST_${ALIAS_NAME}="https://${ACCESS_KEY}:${SECRET_KEY}@${HOST_BASE}"
+mc --config-dir "$MC_CONFIG_DIR" alias ls >/dev/null
 
 echo "[1/3] Текущие notification-правила в бакете $BUCKET:"
-mc event ls "$ALIAS_NAME/$BUCKET" || true
+mc --config-dir "$MC_CONFIG_DIR" event ls "$ALIAS_NAME/$BUCKET" || true
 
 echo "[2/3] Добавление правила: events=$EVENTS target=$TARGET_ARN"
 EVENT_FLAGS=()
@@ -83,9 +91,9 @@ if [[ -n "$SUFFIX" ]]; then
   FILTER_FLAGS+=("--suffix" "$SUFFIX")
 fi
 
-mc event add "$ALIAS_NAME/$BUCKET" "$TARGET_ARN" "${EVENT_FLAGS[@]}" "${FILTER_FLAGS[@]}"
+mc --config-dir "$MC_CONFIG_DIR" event add "$ALIAS_NAME/$BUCKET" "$TARGET_ARN" "${EVENT_FLAGS[@]}" "${FILTER_FLAGS[@]}"
 
 echo "[3/3] Проверка после добавления:"
-mc event ls "$ALIAS_NAME/$BUCKET"
+mc --config-dir "$MC_CONFIG_DIR" event ls "$ALIAS_NAME/$BUCKET"
 
 echo "OK: правило уведомлений настроено"