Fix provider review findings

TOOLS/resource-generator/main.go

@@ -16,6 +16,8 @@
 package main
 
 import (
+	"errors"
+	"fmt"
 	"os"
 	"strings"
 
@@ -23,37 +25,66 @@ import (
 	"resource-generator/internal/writers"
 )
 
+type serviceWriteErr struct {
+	kind string
+	name string
+	err  error
+}
+
 func main() {
+	if err := run(); err != nil {
+		fmt.Fprintf(os.Stderr, "ERROR: %v\n", err)
+		os.Exit(1)
+	}
+}
+
+func run() error {
 	resourcesDir := strings.TrimSpace(os.Getenv("NUBES_RESOURCES_DIR"))
 	if resourcesDir == "" {
-		panic("NUBES_RESOURCES_DIR is required — must point to generated/{stand}/resources_yaml/")
+		return fmt.Errorf("NUBES_RESOURCES_DIR is required — must point to generated/{stand}/resources_yaml/")
 	}
 	outDir := strings.TrimSpace(os.Getenv("NUBES_RESOURCES_GEN_DIR"))
 	if outDir == "" {
-		panic("NUBES_RESOURCES_GEN_DIR is required — must point to generated/{stand}/go/")
+		return fmt.Errorf("NUBES_RESOURCES_GEN_DIR is required — must point to generated/{stand}/go/")
 	}
 
 	instanceResources, subresources, actions, err := loader.LoadSpecs(resourcesDir)
 	if err != nil {
-		panic(err)
+		return err
 	}
 
+	var writeErrs []serviceWriteErr
+
 	for _, svc := range instanceResources {
 		if err := writers.WriteInstanceResource(outDir, svc); err != nil {
-			panic(err)
+			writeErrs = append(writeErrs, serviceWriteErr{kind: "instance", name: svc.Name, err: err})
 		}
 	}
 	for _, sr := range subresources {
 		if err := writers.WriteSubresource(outDir, sr); err != nil {
-			panic(err)
+			name := fmt.Sprintf("%s_%s", sr.ServiceName, sr.SubName)
+			writeErrs = append(writeErrs, serviceWriteErr{kind: "subresource", name: name, err: err})
 		}
 	}
 	for _, act := range actions {
 		if err := writers.WriteActionResource(outDir, act); err != nil {
-			panic(err)
+			name := fmt.Sprintf("%s_%s", act.ServiceName, act.ActionName)
+			writeErrs = append(writeErrs, serviceWriteErr{kind: "action", name: name, err: err})
 		}
 	}
-	if err := writers.WriteRegistry(outDir, instanceResources, subresources, actions); err != nil {
-		panic(err)
+
+	if len(writeErrs) > 0 {
+		var b strings.Builder
+		b.WriteString("generation failed for one or more resources:\n")
+		for _, we := range writeErrs {
+			b.WriteString(fmt.Sprintf("- %s %s: %v\n", we.kind, we.name, we.err))
+		}
+		return errors.New(strings.TrimSpace(b.String()))
 	}
+
+	if err := writers.WriteRegistry(outDir, instanceResources, subresources, actions); err != nil {
+		return err
+	}
+
+	return nil
 }