fix(shared-sqs): deadlock in create_queue, UI sent_at bug, Redis deploy, TLS ingress (v0.1.13-v0.1.14)

- fix: add SyncQueues.Unlock() before return in create_queue.go happy path (deadlock after first CreateQueue) - fix: UI m.sent -> m.sent_at (message dates always showed as dash) - feat: add deployments/k8s/redis.yaml (Redis persistence) - chore: update deployment image to naeel/shared-sqs:v0.1.14 - chore: update ingress.yaml (TLS, qu.kube5s.ru) - docs: add thinking log 2026-04-10
2026-04-10 10:42:08 +03:00
parent c9bce7e751
commit 88d3d12c0c
11 changed files with 411 additions and 273 deletions
@@ -4,63 +4,65 @@
 package gosqs

 import (
-"net/http"
-"time"
+	"net/http"
+	"time"

-"shared-sqs/app/interfaces"
-"shared-sqs/app/models"
-"shared-sqs/app/persistence"
-"shared-sqs/app/utils"
-log "github.com/sirupsen/logrus"
+	"shared-sqs/app/interfaces"
+	"shared-sqs/app/models"
+	"shared-sqs/app/persistence"
+	"shared-sqs/app/utils"
+
+	log "github.com/sirupsen/logrus"
 )

 func CreateQueueV1(req *http.Request) (int, interfaces.AbstractResponseBody) {
-requestBody := models.NewCreateQueueRequest()
-ok := utils.REQUEST_TRANSFORMER(requestBody, req, false)
-if !ok {
-log.Error("Invalid Request - CreateQueueV1")
-return utils.CreateErrorResponseV1("InvalidParameterValue", true)
-}
+	requestBody := models.NewCreateQueueRequest()
+	ok := utils.REQUEST_TRANSFORMER(requestBody, req, false)
+	if !ok {
+		log.Error("Invalid Request - CreateQueueV1")
+		return utils.CreateErrorResponseV1("InvalidParameterValue", true)
+	}

-t := getTenantFromContext(req)
-if t == nil {
-return utils.CreateErrorResponseV1("InvalidClientTokenId", true)
-}
+	t := getTenantFromContext(req)
+	if t == nil {
+		return utils.CreateErrorResponseV1("InvalidClientTokenId", true)
+	}

-// Ловушка #8: передаём queueName (не key) в HasFIFOQueueName — иначе .fifo не определится
-queueName := requestBody.QueueName
-key := tenantQueueKey(t.AccessKey, queueName)
-queueUrl := tenantQueueURL(t, queueName)
-queueArn := tenantQueueARN(t, queueName)
+	// Ловушка #8: передаём queueName (не key) в HasFIFOQueueName — иначе .fifo не определится
+	queueName := requestBody.QueueName
+	key := tenantQueueKey(t.AccessKey, queueName)
+	queueUrl := tenantQueueURL(t, queueName)
+	queueArn := tenantQueueARN(t, queueName)

-models.SyncQueues.Lock()
-if _, exists := models.SyncQueues.Queues[key]; !exists {
-// Проверка лимита очередей тенанта
-if t.MaxQueues > 0 && countTenantQueues(t.AccessKey) >= t.MaxQueues {
-models.SyncQueues.Unlock()
-return utils.CreateErrorResponseV1("LimitExceeded", true)
-}
-log.Infof("Creating Queue: %s (tenant: %s)", queueName, t.ID)
-queue := &models.Queue{
-Name:             queueName,
-URL:              queueUrl,
-Arn:              queueArn,
-IsFIFO:           utils.HasFIFOQueueName(queueName),
-EnableDuplicates: models.CurrentEnvironment.EnableDuplicates,
-Duplicates:       make(map[string]time.Time),
-}
-if err := setQueueAttributesV1(queue, requestBody.Attributes); err != nil {
-models.SyncQueues.Unlock()
-return utils.CreateErrorResponseV1(err.Error(), true)
-}
-models.SyncQueues.Queues[key] = queue
-}
+	models.SyncQueues.Lock()
+	if _, exists := models.SyncQueues.Queues[key]; !exists {
+		// Проверка лимита очередей тенанта
+		if t.MaxQueues > 0 && countTenantQueues(t.AccessKey) >= t.MaxQueues {
+			models.SyncQueues.Unlock()
+			return utils.CreateErrorResponseV1("LimitExceeded", true)
+		}
+		log.Infof("Creating Queue: %s (tenant: %s)", queueName, t.ID)
+		queue := &models.Queue{
+			Name:             queueName,
+			URL:              queueUrl,
+			Arn:              queueArn,
+			IsFIFO:           utils.HasFIFOQueueName(queueName),
+			EnableDuplicates: models.CurrentEnvironment.EnableDuplicates,
+			Duplicates:       make(map[string]time.Time),
+		}
+		if err := setQueueAttributesV1(queue, requestBody.Attributes); err != nil {
+			models.SyncQueues.Unlock()
+			return utils.CreateErrorResponseV1(err.Error(), true)
+		}
+		models.SyncQueues.Queues[key] = queue
+	}
 	// Сохраняем очередь в Redis пока держим Lock — консистентный снапшот
 	persistence.SaveQueue(key, models.SyncQueues.Queues[key])
-respStruct := models.CreateQueueResponse{
-Xmlns:    models.BaseXmlns,
-Result:   models.CreateQueueResult{QueueUrl: queueUrl},
-Metadata: models.BaseResponseMetadata,
-}
-return http.StatusOK, respStruct
+	models.SyncQueues.Unlock()
+	respStruct := models.CreateQueueResponse{
+		Xmlns:    models.BaseXmlns,
+		Result:   models.CreateQueueResult{QueueUrl: queueUrl},
+		Metadata: models.BaseResponseMetadata,
+	}
+	return http.StatusOK, respStruct
 }