Vardhaman SuranaandGitHub
2a40b4538c
- added manager to wait for all go routines to end before exit - code refactor - renamed Manafer to Interface and GoRoutineManager to GroupManager - replaced some go routine calls with manager Add func - added unit tests for manager
38 lines
911 B
Go
38 lines
911 B
Go
package httpserver
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/fission/fission/pkg/utils/manager"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
func StartServer(ctx context.Context, log *zap.Logger, mgr manager.Interface, svc string, port string, handler http.Handler) {
|
|
if !strings.Contains(port, ":") {
|
|
port = fmt.Sprintf(":%s", port)
|
|
}
|
|
server := http.Server{
|
|
Addr: port,
|
|
Handler: handler,
|
|
}
|
|
l := log.With(zap.String("service", svc), zap.String("addr", server.Addr))
|
|
l.Info("starting server")
|
|
mgr.Add(ctx, func(ctx context.Context) {
|
|
if err := server.ListenAndServe(); err != nil {
|
|
if err != http.ErrServerClosed {
|
|
l.Error("server error", zap.Error(err))
|
|
}
|
|
}
|
|
})
|
|
<-ctx.Done()
|
|
l.Info("shutting down server")
|
|
if err := server.Shutdown(ctx); err != nil {
|
|
if err != context.Canceled && err != context.DeadlineExceeded {
|
|
l.Error("server shutdown error", zap.Error(err))
|
|
}
|
|
}
|
|
}
|