* Add staticcheck fixes Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * update golangci-lint version Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> --------- Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
328 lines
9.7 KiB
Go
328 lines
9.7 KiB
Go
/*
|
|
Copyright 2017 The Fission Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package storagesvc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"os"
|
|
"strconv"
|
|
"time"
|
|
|
|
"errors"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/graymeta/stow"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/fission/fission/pkg/crd"
|
|
"github.com/fission/fission/pkg/utils/httpserver"
|
|
"github.com/fission/fission/pkg/utils/manager"
|
|
"github.com/fission/fission/pkg/utils/metrics"
|
|
otelUtils "github.com/fission/fission/pkg/utils/otel"
|
|
)
|
|
|
|
type (
|
|
// Storage is an interface to force storage level details implementation.
|
|
Storage interface {
|
|
getStorageType() StorageType
|
|
dial() (stow.Location, error)
|
|
getSubDir() string
|
|
getContainerName() string
|
|
getUploadFileName() (string, error)
|
|
}
|
|
|
|
// StorageService is a struct to hold all things for storage service
|
|
StorageService struct {
|
|
logger *zap.Logger
|
|
storageClient *StowClient
|
|
port int
|
|
}
|
|
|
|
UploadResponse struct {
|
|
ID string `json:"id"`
|
|
}
|
|
)
|
|
|
|
// Functions handling storage interface
|
|
func getStorageType(storage Storage) string {
|
|
return string(storage.getStorageType())
|
|
}
|
|
|
|
func getStorageLocation(config *storageConfig) (stow.Location, error) {
|
|
return config.storage.dial()
|
|
}
|
|
|
|
func (ss *StorageService) listItems(w http.ResponseWriter, r *http.Request) {
|
|
logger := otelUtils.LoggerWithTraceID(r.Context(), ss.logger)
|
|
// get all archives on storage
|
|
// out of them, there may be some just created but not referenced by packages yet.
|
|
// need to filter them out.
|
|
archivesInStorage, err := ss.storageClient.getItemIDsWithFilter(ss.storageClient.filterAllItems, false)
|
|
if err != nil {
|
|
logger.Error("error getting items from storage", zap.Error(err))
|
|
return
|
|
}
|
|
logger.Debug("archives in storage", zap.Strings("archives", archivesInStorage))
|
|
|
|
// respond with the list of items
|
|
resp, err := json.Marshal(archivesInStorage)
|
|
if err != nil {
|
|
http.Error(w, "error marshaling item list", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
_, err = w.Write(resp)
|
|
if err != nil {
|
|
logger.Error(
|
|
"error writing HTTP response",
|
|
zap.Error(err),
|
|
)
|
|
}
|
|
}
|
|
|
|
// Handle multipart file uploads.
|
|
func (ss *StorageService) uploadHandler(w http.ResponseWriter, r *http.Request) {
|
|
logger := otelUtils.LoggerWithTraceID(r.Context(), ss.logger)
|
|
|
|
// handle upload
|
|
err := r.ParseMultipartForm(0)
|
|
if err != nil {
|
|
http.Error(w, "failed to parse request", http.StatusBadRequest)
|
|
}
|
|
file, handler, err := r.FormFile("uploadfile")
|
|
if err != nil {
|
|
http.Error(w, "missing upload file", http.StatusBadRequest)
|
|
return
|
|
}
|
|
defer file.Close()
|
|
|
|
// stow wants the file size, but that's different from the
|
|
// content length, the content length being the size of the
|
|
// encoded file in the HTTP request. So we require an
|
|
// "X-File-Size" header in bytes.
|
|
|
|
fileSizeS, ok := r.Header["X-File-Size"]
|
|
if !ok {
|
|
logger.Error("upload is missing the 'X-File-Size' header",
|
|
zap.String("filename", handler.Filename))
|
|
http.Error(w, "missing X-File-Size header", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
fileSize, err := strconv.Atoi(fileSizeS[0])
|
|
if err != nil {
|
|
logger.Error("error parsing 'X-File-Size' header",
|
|
zap.Error(err),
|
|
zap.Strings("header", fileSizeS),
|
|
zap.String("filename", handler.Filename))
|
|
http.Error(w, "missing or bad X-File-Size header", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// TODO: allow headers to add more metadata (e.g. environment and function metadata)
|
|
logger.Debug("handling upload",
|
|
zap.String("filename", handler.Filename))
|
|
|
|
id, err := ss.storageClient.putFile(file, int64(fileSize))
|
|
if err != nil {
|
|
logger.Error("error saving uploaded file",
|
|
zap.Error(err),
|
|
zap.String("filename", handler.Filename))
|
|
http.Error(w, "Error saving uploaded file", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
totalMemoryUsage.WithLabelValues().Add(float64(fileSize))
|
|
|
|
// respond with an ID that can be used to retrieve the file
|
|
ur := &UploadResponse{
|
|
ID: id,
|
|
}
|
|
resp, err := json.Marshal(ur)
|
|
if err != nil {
|
|
logger.Error("error marshaling uploaded file response",
|
|
zap.Error(err),
|
|
zap.String("filename", handler.Filename))
|
|
http.Error(w, "Error marshaling response", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
_, err = w.Write(resp)
|
|
if err != nil {
|
|
logger.Error(
|
|
"error writing HTTP response",
|
|
zap.Error(err),
|
|
zap.String("filename", handler.Filename),
|
|
)
|
|
}
|
|
|
|
totalArchives.WithLabelValues().Inc()
|
|
}
|
|
|
|
func (ss *StorageService) getIdFromRequest(r *http.Request) (string, error) {
|
|
values := r.URL.Query()
|
|
ids, ok := values["id"]
|
|
if !ok || len(ids) == 0 {
|
|
return "", errors.New("missing `id' query param")
|
|
}
|
|
return ids[0], nil
|
|
}
|
|
|
|
func (ss *StorageService) deleteHandler(w http.ResponseWriter, r *http.Request) {
|
|
// get id from request
|
|
fileId, err := ss.getIdFromRequest(r)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
filesize, err := ss.storageClient.getFileSize(fileId)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
}
|
|
|
|
err = ss.storageClient.removeFileByID(fileId)
|
|
if err != nil {
|
|
msg := fmt.Sprintf("Error deleting item: %v", err)
|
|
http.Error(w, msg, http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
totalArchives.WithLabelValues().Dec()
|
|
totalMemoryUsage.WithLabelValues().Sub(float64(filesize))
|
|
w.WriteHeader(http.StatusOK)
|
|
}
|
|
|
|
func (ss *StorageService) downloadHandler(w http.ResponseWriter, r *http.Request) {
|
|
logger := otelUtils.LoggerWithTraceID(r.Context(), ss.logger)
|
|
|
|
// get id from request
|
|
fileId, err := ss.getIdFromRequest(r)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
// Get the file (called "item" in stow's jargon), open it,
|
|
// stream it to response
|
|
err = ss.storageClient.copyFileToStream(fileId, w)
|
|
if err != nil {
|
|
logger.Error("error getting file from storage client", zap.Error(err), zap.String("file_id", fileId))
|
|
if err == ErrNotFound {
|
|
http.Error(w, "Error retrieving item: not found", http.StatusNotFound)
|
|
} else if err == ErrRetrievingItem {
|
|
http.Error(w, "Error retrieving item", http.StatusBadRequest)
|
|
} else if err == ErrOpeningItem {
|
|
http.Error(w, "Error opening item", http.StatusBadRequest)
|
|
} else if err == ErrWritingFileIntoResponse {
|
|
http.Error(w, "Error writing response", http.StatusInternalServerError)
|
|
}
|
|
return
|
|
}
|
|
}
|
|
|
|
func (ss *StorageService) infoHandler(w http.ResponseWriter, r *http.Request) {
|
|
|
|
fileID, err := ss.getIdFromRequest(r)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
_, err = ss.storageClient.container.Item(fileID)
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusNotFound)
|
|
return
|
|
}
|
|
|
|
storageType := ss.storageClient.config.storage.getStorageType()
|
|
if storageType == StorageTypeS3 {
|
|
w.Header().Add("X-FISSION-BUCKET", ss.storageClient.config.storage.getContainerName())
|
|
}
|
|
w.Header().Add("X-FISSION-STORAGETYPE", string(storageType))
|
|
}
|
|
|
|
func (ss *StorageService) healthHandler(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
}
|
|
|
|
func MakeStorageService(logger *zap.Logger, storageClient *StowClient, port int) *StorageService {
|
|
return &StorageService{
|
|
logger: logger.Named("storage_service"),
|
|
storageClient: storageClient,
|
|
port: port,
|
|
}
|
|
}
|
|
|
|
func (ss *StorageService) Start(ctx context.Context, mgr manager.Interface, port int) {
|
|
r := mux.NewRouter()
|
|
r.Use(metrics.HTTPMetricMiddleware)
|
|
r.HandleFunc("/v1/archive", ss.uploadHandler).Methods("POST")
|
|
r.HandleFunc("/v1/archive", ss.downloadHandler).Queries("id", "{id}").Methods("GET")
|
|
r.HandleFunc("/v1/archive", ss.listItems).Methods("GET")
|
|
r.HandleFunc("/v1/archive", ss.deleteHandler).Methods("DELETE")
|
|
r.HandleFunc("/v1/archive", ss.infoHandler).Methods("HEAD")
|
|
r.HandleFunc("/healthz", ss.healthHandler).Methods("GET")
|
|
|
|
handler := otelUtils.GetHandlerWithOTEL(r, "fission-storagesvc", otelUtils.UrlsToIgnore("/healthz"))
|
|
httpserver.StartServer(ctx, ss.logger, mgr, "storagesvc", fmt.Sprintf("%d", port), handler)
|
|
}
|
|
|
|
// Start runs storage service
|
|
func Start(ctx context.Context, clientGen crd.ClientGeneratorInterface, logger *zap.Logger, storage Storage, mgr manager.Interface, port int) error {
|
|
enablePruner, err := strconv.ParseBool(os.Getenv("PRUNE_ENABLED"))
|
|
if err != nil {
|
|
logger.Warn("PRUNE_ENABLED value not set. Enabling archive pruner by default.", zap.Error(err))
|
|
enablePruner = true
|
|
}
|
|
// create a storage client
|
|
storageClient, err := MakeStowClient(logger, storage)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating stowClient: %w", err)
|
|
}
|
|
|
|
// create http handlers
|
|
storageService := MakeStorageService(logger, storageClient, port)
|
|
mgr.Add(ctx, func(ctx context.Context) {
|
|
metrics.ServeMetrics(ctx, "storagesvc", logger, mgr)
|
|
})
|
|
|
|
mgr.Add(ctx, func(ctx context.Context) {
|
|
storageService.Start(ctx, mgr, port)
|
|
})
|
|
|
|
// enablePruner prevents storagesvc unit test from needing to talk to kubernetes
|
|
if enablePruner {
|
|
// get the prune interval and start the archive pruner
|
|
pruneInterval, err := strconv.Atoi(os.Getenv("PRUNE_INTERVAL"))
|
|
if err != nil {
|
|
pruneInterval = defaultPruneInterval
|
|
}
|
|
pruner, err := MakeArchivePruner(logger, clientGen, storageClient, time.Duration(pruneInterval))
|
|
if err != nil {
|
|
return fmt.Errorf("error creating archivePruner: %w", err)
|
|
}
|
|
mgr.Add(ctx, func(ctx context.Context) {
|
|
pruner.Start(ctx, mgr)
|
|
})
|
|
}
|
|
|
|
logger.Info("storage service started")
|
|
return nil
|
|
}
|