* Optimize router response time by adding update lock In 0.9.2, the router sends multiple GetServiceForFunction requests to executor to get the service URL. However, the response time of executor will increase under high-concurrency situation due to too many requests are waiting for processing. To solve the problem, an update lock was added to the router. All of goroutines belongs to the same function need to grab the update lock before sending the request. Only the first goroutine which gets the update lock is allowed to send request. In this way, we reduce the burden of executor and lower the failure rate.
271 lines
7.7 KiB
Go
271 lines
7.7 KiB
Go
/*
|
|
Copyright 2016 The Fission Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package executor
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
"net/http"
|
|
"runtime/debug"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/dchest/uniuri"
|
|
"github.com/pkg/errors"
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
"github.com/fission/fission"
|
|
"github.com/fission/fission/cache"
|
|
"github.com/fission/fission/crd"
|
|
"github.com/fission/fission/executor/fscache"
|
|
"github.com/fission/fission/executor/newdeploy"
|
|
"github.com/fission/fission/executor/poolmgr"
|
|
"github.com/fission/fission/executor/reaper"
|
|
)
|
|
|
|
type (
|
|
Executor struct {
|
|
gpm *poolmgr.GenericPoolManager
|
|
ndm *newdeploy.NewDeploy
|
|
functionEnv *cache.Cache
|
|
fissionClient *crd.FissionClient
|
|
fsCache *fscache.FunctionServiceCache
|
|
|
|
requestChan chan *createFuncServiceRequest
|
|
fsCreateWg map[string]*sync.WaitGroup
|
|
}
|
|
createFuncServiceRequest struct {
|
|
funcMeta *metav1.ObjectMeta
|
|
respChan chan *createFuncServiceResponse
|
|
}
|
|
|
|
createFuncServiceResponse struct {
|
|
funcSvc *fscache.FuncSvc
|
|
err error
|
|
}
|
|
)
|
|
|
|
func MakeExecutor(gpm *poolmgr.GenericPoolManager, ndm *newdeploy.NewDeploy, fissionClient *crd.FissionClient, fsCache *fscache.FunctionServiceCache) *Executor {
|
|
executor := &Executor{
|
|
gpm: gpm,
|
|
ndm: ndm,
|
|
functionEnv: cache.MakeCache(10*time.Second, 0),
|
|
fissionClient: fissionClient,
|
|
fsCache: fsCache,
|
|
|
|
requestChan: make(chan *createFuncServiceRequest),
|
|
fsCreateWg: make(map[string]*sync.WaitGroup),
|
|
}
|
|
go executor.serveCreateFuncServices()
|
|
|
|
return executor
|
|
}
|
|
|
|
// All non-cached function service requests go through this goroutine
|
|
// serially. It parallelizes requests for different functions, and
|
|
// ensures that for a given function, only one request causes a pod to
|
|
// get specialized. In other words, it ensures that when there's an
|
|
// ongoing request for a certain function, all other requests wait for
|
|
// that request to complete.
|
|
func (executor *Executor) serveCreateFuncServices() {
|
|
for {
|
|
req := <-executor.requestChan
|
|
m := req.funcMeta
|
|
|
|
// Cache miss -- is this first one to request the func?
|
|
wg, found := executor.fsCreateWg[crd.CacheKey(m)]
|
|
if !found {
|
|
// create a waitgroup for other requests for
|
|
// the same function to wait on
|
|
wg := &sync.WaitGroup{}
|
|
wg.Add(1)
|
|
executor.fsCreateWg[crd.CacheKey(m)] = wg
|
|
|
|
// launch a goroutine for each request, to parallelize
|
|
// the specialization of different functions
|
|
go func() {
|
|
fsvc, err := executor.createServiceForFunction(m)
|
|
req.respChan <- &createFuncServiceResponse{
|
|
funcSvc: fsvc,
|
|
err: err,
|
|
}
|
|
delete(executor.fsCreateWg, crd.CacheKey(m))
|
|
wg.Done()
|
|
}()
|
|
} else {
|
|
// There's an existing request for this function, wait for it to finish
|
|
go func() {
|
|
log.Printf("Waiting for concurrent request for the same function: %v", m)
|
|
wg.Wait()
|
|
|
|
// get the function service from the cache
|
|
fsvc, err := executor.fsCache.GetByFunction(m)
|
|
|
|
// fsCache return error when the entry does not exist/expire.
|
|
// It normally happened if there are multiple requests are
|
|
// waiting for the same function and executor failed to cre-
|
|
// ate service for function.
|
|
err = errors.Wrap(err, fmt.Sprintf("Error getting service for function %v in namespace %v", m.Name, m.Namespace))
|
|
req.respChan <- &createFuncServiceResponse{
|
|
funcSvc: fsvc,
|
|
err: err,
|
|
}
|
|
}()
|
|
}
|
|
}
|
|
}
|
|
|
|
func (executor *Executor) getFunctionExecutorType(meta *metav1.ObjectMeta) (fission.ExecutorType, error) {
|
|
fn, err := executor.fissionClient.Functions(meta.Namespace).Get(meta.Name)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return fn.Spec.InvokeStrategy.ExecutionStrategy.ExecutorType, nil
|
|
}
|
|
|
|
func (executor *Executor) createServiceForFunction(meta *metav1.ObjectMeta) (*fscache.FuncSvc, error) {
|
|
log.Printf("[%v] No cached function service found, creating one", meta.Name)
|
|
|
|
executorType, err := executor.getFunctionExecutorType(meta)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var fsvc *fscache.FuncSvc
|
|
var fsvcErr error
|
|
|
|
switch executorType {
|
|
case fission.ExecutorTypeNewdeploy:
|
|
fsvc, fsvcErr = executor.ndm.GetFuncSvc(meta)
|
|
default:
|
|
// from Func -> get Env
|
|
log.Printf("[%v] getting environment for function", meta.Name)
|
|
env, err := executor.getFunctionEnv(meta)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
pool, err := executor.gpm.GetPool(env)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
// from GenericPool -> get one function container
|
|
// (this also adds to the cache)
|
|
log.Printf("[%v] getting function service from pool", meta.Name)
|
|
fsvc, fsvcErr = pool.GetFuncSvc(meta)
|
|
}
|
|
|
|
if fsvcErr != nil {
|
|
fsvcErr = errors.Wrap(fsvcErr, fmt.Sprintf("[%v] Error creating service for function", meta.Name))
|
|
log.Print(fsvcErr)
|
|
}
|
|
|
|
return fsvc, fsvcErr
|
|
}
|
|
|
|
func (executor *Executor) getFunctionEnv(m *metav1.ObjectMeta) (*crd.Environment, error) {
|
|
var env *crd.Environment
|
|
|
|
// Cached ?
|
|
result, err := executor.functionEnv.Get(crd.CacheKey(m))
|
|
if err == nil {
|
|
env = result.(*crd.Environment)
|
|
return env, nil
|
|
}
|
|
|
|
// Cache miss -- get func from controller
|
|
f, err := executor.fissionClient.Functions(m.Namespace).Get(m.Name)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Get env from metadata
|
|
log.Printf("[%v] getting env", m)
|
|
env, err = executor.fissionClient.Environments(f.Spec.Environment.Namespace).Get(f.Spec.Environment.Name)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// cache for future lookups
|
|
executor.functionEnv.Set(crd.CacheKey(m), env)
|
|
|
|
return env, nil
|
|
}
|
|
|
|
// isValidAddress invokes isValidService or isValidPod depending on the type of executor
|
|
func (executor *Executor) isValidAddress(fsvc *fscache.FuncSvc) bool {
|
|
if fsvc.Executor == fscache.NEWDEPLOY {
|
|
return executor.ndm.IsValid(fsvc)
|
|
} else {
|
|
return executor.gpm.IsValid(fsvc)
|
|
}
|
|
}
|
|
|
|
func dumpStackTrace() {
|
|
debug.PrintStack()
|
|
}
|
|
|
|
func serveMetric() {
|
|
// Expose the registered metrics via HTTP.
|
|
metricAddr := ":8080"
|
|
http.Handle("/metrics", promhttp.Handler())
|
|
log.Fatal(http.ListenAndServe(metricAddr, nil))
|
|
}
|
|
|
|
// StartExecutor Starts executor and the executor components such as Poolmgr,
|
|
// deploymgr and potential future executor types
|
|
func StartExecutor(fissionNamespace string, functionNamespace string, envBuilderNamespace string, port int) error {
|
|
// setup a signal handler for SIGTERM
|
|
fission.SetupStackTraceHandler()
|
|
|
|
fissionClient, kubernetesClient, _, err := crd.MakeFissionClient()
|
|
|
|
err = fissionClient.WaitForCRDs()
|
|
if err != nil {
|
|
log.Fatalf("Error waiting for CRDs: %v", err)
|
|
}
|
|
|
|
restClient := fissionClient.GetCrdClient()
|
|
if err != nil {
|
|
log.Printf("Failed to get kubernetes client: %v", err)
|
|
return err
|
|
}
|
|
|
|
fsCache := fscache.MakeFunctionServiceCache()
|
|
|
|
poolID := strings.ToLower(uniuri.NewLen(8))
|
|
reaper.CleanupOldExecutorObjects(kubernetesClient, poolID)
|
|
go reaper.CleanupRoleBindings(kubernetesClient, fissionClient, functionNamespace, envBuilderNamespace, time.Minute*30)
|
|
|
|
gpm := poolmgr.MakeGenericPoolManager(
|
|
fissionClient, kubernetesClient,
|
|
functionNamespace, fsCache, poolID)
|
|
|
|
ndm := newdeploy.MakeNewDeploy(
|
|
fissionClient, kubernetesClient, restClient,
|
|
functionNamespace, fsCache, poolID)
|
|
|
|
api := MakeExecutor(gpm, ndm, fissionClient, fsCache)
|
|
|
|
go api.Serve(port)
|
|
go serveMetric()
|
|
|
|
return nil
|
|
}
|