Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed typos across fission repo (#1832)

Browse Source 
Co-authored-by: Vishal <vishal-biyani@users.noreply.github.com>
This commit is contained in:
Gaurav Gahlot
2020-10-16 17:25:11 +05:30
committed by GitHub
co-authored by Vishal
parent 6e3c42f238
commit fca0a60e5b
49 changed files with 157 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/preupgradechecks/Dockerfile.fission-preupgradechecks
+1 -1
View File
@@ -12,7 +12,7 @@ COPY go.* ./
RUN go mod download
From godep as builder
FROM godep as builder
ARG GOPKG
WORKDIR /go/src/${GOPKG}
cmd/preupgradechecks/preupgradechecks.go
+4 -4
View File
@@ -64,7 +64,7 @@ func makePreUpgradeTaskClient(logger *zap.Logger, fnPodNs, envBuilderNs string)
}, nil
}
// IsFissionReInstall checks if there is atleast one fission CRD, i.e. function in this case, on this cluster.
// IsFissionReInstall checks if there is at least one fission CRD, i.e. function in this case, on this cluster.
// We need this to find out if fission had been previously installed on this cluster
func (client *PreUpgradeTaskClient) IsFissionReInstall() bool {
for i := 0; i < maxRetries; i++ {
@@ -158,10 +158,10 @@ func (client *PreUpgradeTaskClient) RemoveClusterAdminRolesForFissionSAs() {
}
}
client.logger.Info("femoved cluster admin privileges for fission-builder and fission-fetcher service accounts")
client.logger.Info("removed cluster admin privileges for fission-builder and fission-fetcher service accounts")
}
// NeedRoleBindings checks if there is atleast one package or function in default namespace.
// NeedRoleBindings checks if there is at least one package or function in default namespace.
// It is needed to find out if package-getter-rb and secret-configmap-getter-rb needs to be created for fission-fetcher
// and fission-builder service accounts.
// This is because, we just deleted the ClusterRoleBindings for these service accounts in the previous function and
@@ -180,7 +180,7 @@ func (client *PreUpgradeTaskClient) NeedRoleBindings() bool {
return false
}
// Setup appropriate role bindings for fission-fetcher and fission-builder SAs
// SetupRoleBindings sets appropriate role bindings for fission-fetcher and fission-builder SAs
func (client *PreUpgradeTaskClient) SetupRoleBindings() {
if !client.NeedRoleBindings() {
client.logger.Info("no fission objects found, so no role-bindings to create")