Adopt custom defaulter and validator interface for webhooks intead of deprecated default (#3152)

* Move webhooks to webhooks package Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * change interface Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * Change interface methods Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * comment debug logs for now Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * rename files Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * Fix webhook warnings Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * Update makefile Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * lint fixes Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> --------- Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
2025-01-23 15:36:07 +05:30
parent 38ec6528e3
commit fb60a14ecc
16 changed files with 658 additions and 587 deletions
@@ -0,0 +1,103 @@
+/*
+Copyright 2022.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package webhook
+
+import (
+	"context"
+	"fmt"
+	"os"
+
+	// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
+	// to ensure that exec-entrypoint and run can make use of them.
+
+	"github.com/go-logr/zapr"
+	"go.uber.org/zap"
+	_ "k8s.io/client-go/plugin/pkg/client/auth"
+	"sigs.k8s.io/controller-runtime/pkg/log"
+	"sigs.k8s.io/controller-runtime/pkg/manager"
+
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
+	"sigs.k8s.io/controller-runtime/pkg/webhook"
+
+	"github.com/fission/fission/pkg/crd"
+	"github.com/fission/fission/pkg/generated/clientset/versioned/scheme"
+	//+kubebuilder:scaffold:imports
+)
+
+type WebhookInjector interface {
+	SetupWebhookWithManager(mgr manager.Manager) error
+}
+
+func Start(ctx context.Context, clientGen crd.ClientGeneratorInterface, logger *zap.Logger, options webhook.Options) (err error) {
+	wLogger := logger.Named("webhook")
+	zaprLogger := zapr.NewLogger(logger)
+	log.SetLogger(zaprLogger)
+
+	metricsAddr := os.Getenv("METRICS_ADDR")
+	if metricsAddr == "" {
+		metricsAddr = ":8080"
+	}
+	if metricsAddr[0] != ':' {
+		metricsAddr = fmt.Sprintf(":%s", metricsAddr)
+	}
+	mgrOpt := manager.Options{
+		Scheme: scheme.Scheme,
+		Metrics: metricsserver.Options{
+			BindAddress: metricsAddr,
+		},
+		WebhookServer: webhook.NewServer(options),
+		Logger:        zaprLogger,
+	}
+	restConfig, err := clientGen.GetRestConfig()
+	if err != nil {
+		wLogger.Error("unable to get rest config", zap.Error(err))
+		return err
+	}
+	// Setup a Manager
+	mgr, err := manager.New(restConfig, mgrOpt)
+	if err != nil {
+		wLogger.Error("unable to set up overall controller manager", zap.Error(err))
+		return err
+	}
+
+	// Setup webhooks
+
+	webhookInjectors := []WebhookInjector{
+		&CanaryConfig{},
+		&Environment{},
+		&Package{},
+		&Function{},
+		&HTTPTrigger{},
+		&MessageQueueTrigger{},
+		&TimeTrigger{},
+		&KubernetesWatchTrigger{},
+	}
+
+	for _, injector := range webhookInjectors {
+		if err := injector.SetupWebhookWithManager(mgr); err != nil {
+			wLogger.Error("unable to create webhook", zap.Error(err))
+			return err
+		}
+	}
+
+	wLogger.Info("starting manager")
+	if err := mgr.Start(ctx); err != nil {
+		wLogger.Error("unable to run manager", zap.Error(err))
+		return err
+	}
+	return nil
+}