diff --git a/charts/fission-all/templates/_helpers.tpl b/charts/fission-all/templates/_helpers.tpl index b553b5af..60a157d6 100644 --- a/charts/fission-all/templates/_helpers.tpl +++ b/charts/fission-all/templates/_helpers.tpl @@ -37,38 +37,37 @@ auth: {{- end -}} {{/* -This template generates the image name for the deployment depending on the value of "repository" field in values.yaml file. +Helper template to construct image names with repository and tag */}} -{{- define "fission-bundleImage" -}} -{{- if .Values.repository -}} - {{- if eq .Values.imageTag "" -}} - {{ .Values.repository }}/{{ .Values.image }} - {{- else -}} - {{ .Values.repository }}/{{ .Values.image }}:{{ .Values.imageTag }} - {{- end }} +{{- define "imageWithTag" -}} +{{- $repository := index . 0 -}} +{{- $image := index . 1 -}} +{{- $tag := index . 2 -}} +{{- if $repository -}} +{{- printf "%s/%s%s" $repository $image (ne $tag "" | ternary (printf ":%s" $tag) "") -}} {{- else -}} - {{- if eq .Values.imageTag "" -}} - {{ .Values.image }} - {{- else -}} - {{ .Values.image }}:{{ .Values.imageTag }} - {{- end }} -{{- end }} +{{- printf "%s%s" $image (ne $tag "" | ternary (printf ":%s" $tag) "") -}} +{{- end -}} +{{- end -}} + +{{- define "fission-bundleImage" -}} +{{- $args := list .Values.repository .Values.image .Values.imageTag -}} +{{- include "imageWithTag" $args -}} {{- end -}} {{- define "reporterImage" -}} -{{- if .Values.repository -}} - {{- if eq .Values.imageTag "" -}} - {{ .Values.repository }}/{{ .Values.postInstallReportImage }} - {{- else -}} - {{ .Values.repository }}/{{ .Values.postInstallReportImage }}:{{ .Values.imageTag }} - {{- end }} -{{- else -}} - {{- if eq .Values.imageTag "" -}} - {{ .Values.postInstallReportImage }} - {{- else -}} - {{ .Values.postInstallReportImage }}:{{ .Values.imageTag }} - {{- end }} -{{- end }} +{{- $args := list .Values.repository .Values.postInstallReportImage .Values.imageTag -}} +{{- include "imageWithTag" $args -}} +{{- end -}} + +{{- define "fetcherImage" -}} +{{- $args := list (.Values.fetcher.repository | default .Values.repository) .Values.fetcher.image .Values.fetcher.imageTag -}} +{{- include "imageWithTag" $args -}} +{{- end -}} + +{{- define "preUpgradeChecksImage" -}} +{{- $args := list (.Values.preUpgradeChecks.repository | default .Values.repository) .Values.preUpgradeChecks.image .Values.preUpgradeChecks.imageTag -}} +{{- include "imageWithTag" $args -}} {{- end -}} {{- define "opentelemtry.envs" }} diff --git a/charts/fission-all/templates/buildermgr/deployment.yaml b/charts/fission-all/templates/buildermgr/deployment.yaml index 360f128e..ec82dd98 100644 --- a/charts/fission-all/templates/buildermgr/deployment.yaml +++ b/charts/fission-all/templates/buildermgr/deployment.yaml @@ -30,11 +30,7 @@ spec: args: ["--builderMgr", "--storageSvcUrl", "http://storagesvc.{{ .Release.Namespace }}"] env: - name: FETCHER_IMAGE - {{- if eq .Values.fetcher.imageTag "" }} - value: "{{ .Values.fetcher.image }}" - {{- else }} - value: "{{ .Values.fetcher.image }}:{{ .Values.fetcher.imageTag }}" - {{- end }} + value: {{ include "fetcherImage" . | quote }} - name: FETCHER_IMAGE_PULL_POLICY value: "{{ .Values.pullPolicy }}" - name: BUILDER_IMAGE_PULL_POLICY diff --git a/charts/fission-all/templates/executor/deployment.yaml b/charts/fission-all/templates/executor/deployment.yaml index 78e784a2..b21cec7f 100644 --- a/charts/fission-all/templates/executor/deployment.yaml +++ b/charts/fission-all/templates/executor/deployment.yaml @@ -30,11 +30,7 @@ spec: args: ["--executorPort", "8888"] env: - name: FETCHER_IMAGE - {{- if eq .Values.fetcher.imageTag "" }} - value: "{{ .Values.fetcher.image }}" - {{- else }} - value: "{{ .Values.fetcher.image }}:{{ .Values.fetcher.imageTag }}" - {{- end }} + value: {{ include "fetcherImage" . | quote }} - name: FETCHER_IMAGE_PULL_POLICY value: "{{ .Values.pullPolicy }}" - name: RUNTIME_IMAGE_PULL_POLICY diff --git a/charts/fission-all/templates/pre-upgrade-checks/pre-upgrade-job.yaml b/charts/fission-all/templates/pre-upgrade-checks/pre-upgrade-job.yaml index 87a32510..fcd6d339 100644 --- a/charts/fission-all/templates/pre-upgrade-checks/pre-upgrade-job.yaml +++ b/charts/fission-all/templates/pre-upgrade-checks/pre-upgrade-job.yaml @@ -28,11 +28,7 @@ spec: restartPolicy: Never containers: - name: pre-upgrade-job - {{- if .Values.preUpgradeChecks.imageTag }} - image: {{ .Values.preUpgradeChecks.image }}:{{ .Values.preUpgradeChecks.imageTag }} - {{- else }} - image: {{ .Values.preUpgradeChecks.image }} - {{- end }} + image: {{ include "preUpgradeChecksImage" . | quote }} imagePullPolicy: {{ .Values.pullPolicy }} command: [ "/pre-upgrade-checks" ] env: diff --git a/charts/fission-all/values.yaml b/charts/fission-all/values.yaml index ede41ed9..ee496a5c 100644 --- a/charts/fission-all/values.yaml +++ b/charts/fission-all/values.yaml @@ -117,6 +117,10 @@ kubernetesClientBurst: 500 ## fetcher helps in fetching function source code/build and uploading it when function is invoked. ## fetcher: + ## repository represents the repository of the fetcher component. + ## + ## By default, it is empty, which means global repository will be used. + repository: "" ## image represents the image of the fetcher component. image: fission/fetcher ## imageTag represents the tag of the image of the fetcher component. @@ -683,6 +687,10 @@ preUpgradeChecks: ## Run pre-install/pre-upgrade checks if true ## enabled: true + ## Repository for pre-install/pre-upgrade checks image + ## By default it uses the global repository + ## + repository: "" ## pre-install/pre-upgrade checks live in this image ## image: fission/pre-upgrade-checks diff --git a/pkg/fetcher/config/config.go b/pkg/fetcher/config/config.go index 07c47cd6..b0775a4a 100644 --- a/pkg/fetcher/config/config.go +++ b/pkg/fetcher/config/config.go @@ -69,7 +69,7 @@ func MakeFetcherConfig(sharedMountPath string) (*Config, error) { fetcherImage := os.Getenv("FETCHER_IMAGE") if len(fetcherImage) == 0 { - fetcherImage = "fission/fetcher" + fetcherImage = "ghcr.io/fission/fetcher" } fetcherImagePullPolicy := os.Getenv("FETCHER_IMAGE_PULL_POLICY")