Capture context from cobra CLI and pass forward (#2551)

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
This commit is contained in:
Sanket Sudake
2022-09-22 13:54:05 +05:30
committed by GitHub
parent d03395949b
commit e87c84ee2c
33 changed files with 93 additions and 83 deletions
+2 -2
View File
@@ -88,11 +88,11 @@ func MakeFissionClient() (versioned.Interface, kubernetes.Interface, apiextensio
}
// WaitForCRDs does a timeout to check if CRDs have been installed
func WaitForCRDs(fissionClient versioned.Interface) error {
func WaitForCRDs(ctx context.Context, fissionClient versioned.Interface) error {
start := time.Now()
for {
fi := fissionClient.CoreV1().Functions(metav1.NamespaceDefault)
_, err := fi.List(context.TODO(), metav1.ListOptions{})
_, err := fi.List(ctx, metav1.ListOptions{})
if err != nil {
time.Sleep(100 * time.Millisecond)
} else {
+2 -2
View File
@@ -27,7 +27,7 @@ import (
)
// EnsureFissionCRDs checks if all Fission CRDs are present
func EnsureFissionCRDs(logger *zap.Logger, clientset apiextensionsclient.Interface) error {
func EnsureFissionCRDs(ctx context.Context, logger *zap.Logger, clientset apiextensionsclient.Interface) error {
crdsExpected := []string{
"canaryconfigs.fission.io",
"environments.fission.io",
@@ -40,7 +40,7 @@ func EnsureFissionCRDs(logger *zap.Logger, clientset apiextensionsclient.Interfa
}
errs := &multierror.Error{}
for _, crdName := range crdsExpected {
crd, err := clientset.ApiextensionsV1().CustomResourceDefinitions().Get(context.TODO(), crdName, metav1.GetOptions{})
crd, err := clientset.ApiextensionsV1().CustomResourceDefinitions().Get(ctx, crdName, metav1.GetOptions{})
if err != nil {
errs = multierror.Append(errs, fmt.Errorf("CRD %s not found: %s", crdName, err))
}