Capture context from cobra CLI and pass forward (#2551)
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
This commit is contained in:
@@ -41,7 +41,7 @@ func Start(ctx context.Context, logger *zap.Logger, routerUrl string) error {
|
||||
return errors.Wrap(err, "failed to get fission or kubernetes client")
|
||||
}
|
||||
|
||||
err = crd.WaitForCRDs(fissionClient)
|
||||
err = crd.WaitForCRDs(ctx, fissionClient)
|
||||
if err != nil {
|
||||
return errors.Wrap(err, "error waiting for CRDs")
|
||||
}
|
||||
|
||||
@@ -16,7 +16,6 @@ limitations under the License.
|
||||
package app
|
||||
|
||||
import (
|
||||
"context"
|
||||
"log"
|
||||
|
||||
"github.com/spf13/cobra"
|
||||
@@ -50,13 +49,11 @@ func eventCommandHandler(cmd *cobra.Command, args []string) error {
|
||||
return err
|
||||
}
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
t, err := tracker.NewTracker()
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
return t.SendEvent(ctx, event)
|
||||
return t.SendEvent(cmd.Context(), event)
|
||||
}
|
||||
|
||||
// EventCommand reports an event to analytics
|
||||
|
||||
Reference in New Issue
Block a user