Bump Go version to 1.12 (#1290)

.travis.yml

@@ -9,7 +9,7 @@ branches:
 language: go
 
 go:
-  - 1.11.6
+  - 1.12.x
 
 env:
   - KUBECONFIG=${HOME}/.kube/config PATH=$HOME/k8scli:$HOME/tool:$HOME/google-cloud-sdk/bin:${PATH} GO111MODULE=on DOCKER_CACHE_DIR=${HOME}/docker/

cmd/builder/Dockerfile.fission-builder

@@ -1,7 +1,7 @@
 FROM alpine:3.10 as base
 RUN apk add --update ca-certificates
 
-FROM golang:1.11-alpine as fission-builder
+FROM golang:1.12-alpine as fission-builder
 RUN apk add bash ca-certificates git gcc g++ libc-dev
 
 ARG GOPKG=github.com/fission/fission

cmd/fetcher/Dockerfile.fission-fetcher

@@ -1,7 +1,7 @@
 FROM alpine:3.10 as base
 RUN apk add --update ca-certificates
 
-FROM golang:1.11-alpine as builder
+FROM golang:1.12-alpine as builder
 RUN apk add bash ca-certificates git gcc g++ libc-dev
 
 ARG GOPKG=github.com/fission/fission

cmd/fission-bundle/Dockerfile.fission-bundle

@@ -1,7 +1,7 @@
 FROM alpine:3.10 as base
 RUN apk add --update ca-certificates
 
-FROM golang:1.11-alpine as builder
+FROM golang:1.12-alpine as builder
 RUN apk add bash ca-certificates git gcc g++ libc-dev
 
 ARG GOPKG=github.com/fission/fission

hack/verify-govet.sh

@@ -4,12 +4,4 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-find_files() {
+go vet -v $(go list ./...| grep -v vendor)
-  find . -not \( \
-      \( \
-        -wholename '*/vendor/*' \
-      \) -prune \
-    \) -name '*.go'
-}
-
-find_files | xargs -I@ bash -c "go tool vet @"

pkg/executor/executor.go

@@ -128,9 +128,7 @@ func (executor *Executor) serveCreateFuncServices() {
 				// It normally happened if there are multiple requests are
 				// waiting for the same function and executor failed to cre-
 				// ate service for function.
-				err = errors.Wrapf(err, "error getting service for function",
+				err = errors.Wrapf(err, "error getting service for function %v in namespace %v", m.Name, m.Namespace)
-					zap.String("function_name", m.Name),
-					zap.String("function_namespace", m.Namespace))
 				req.respChan <- &createFuncServiceResponse{
 					funcSvc: fsvc,
 					err:     err,