security: Update go-uuid and mholt/archiver to recommended version (#2216)

* security: Update go-uuid to recommended version
* security: Update mholt/archiver dep to recommended version

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

pkg/fission-cli/cmd/function/create.go

@@ -214,7 +214,11 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 		}
 
 		buildcmd := input.String(flagkey.PkgBuildCmd)
-		pkgName := fmt.Sprintf("%v-%v", fnName, uuid.NewV4().String())
+		id, err := uuid.NewV4()
+		if err != nil {
+			return errors.Wrap(err, "error generating uuid")
+		}
+		pkgName := fmt.Sprintf("%v-%v", fnName, id.String())
 
 		// create new package in the same namespace as the function.
 		pkgMetadata, err = _package.CreatePackage(input, opts.Client(), pkgName, fnNamespace, envName, envNamespace,
@@ -363,7 +367,11 @@ func (opts *CreateSubCommand) run(input cli.Input) error {
 		}
 	}
 
-	triggerName := uuid.NewV4().String()
+	id, err := uuid.NewV4()
+	if err != nil {
+		return errors.Wrap(err, "error generating UUID")
+	}
+	triggerName := id.String()
 	ht := &fv1.HTTPTrigger{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      triggerName,

pkg/fission-cli/cmd/httptrigger/create.go

@@ -70,7 +70,11 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 	// just name triggers by uuid.
 	if len(triggerName) == 0 {
 		console.Warn(fmt.Sprintf("--%v will be soon marked as required flag, see 'help' for details", flagkey.HtName))
-		triggerName = uuid.NewV4().String()
+		id, err := uuid.NewV4()
+		if err != nil {
+			return err
+		}
+		triggerName = id.String()
 	}
 	fnNamespace := input.String(flagkey.NamespaceFunction)
 

pkg/fission-cli/cmd/kubewatch/create.go

@@ -53,7 +53,11 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 	watchName := input.String(flagkey.KwName)
 	if len(watchName) == 0 {
 		console.Warn(fmt.Sprintf("--%v will be soon marked as required flag, see 'help' for details", flagkey.MqtName))
-		watchName = uuid.NewV4().String()
+		id, err := uuid.NewV4()
+		if err != nil {
+			return errors.Wrap(err, "error generating uuid")
+		}
+		watchName = id.String()
 	}
 	fnName := input.String(flagkey.KwFnName)
 	fnNamespace := input.String(flagkey.NamespaceFunction)

pkg/fission-cli/cmd/mqtrigger/create.go

@@ -54,7 +54,11 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 	mqtName := input.String(flagkey.MqtName)
 	if len(mqtName) == 0 {
 		console.Warn(fmt.Sprintf("--%v will be soon marked as required flag, see 'help' for details", flagkey.MqtName))
-		mqtName = uuid.NewV4().String()
+		id, err := uuid.NewV4()
+		if err != nil {
+			return err
+		}
+		mqtName = id.String()
 	}
 	fnName := input.String(flagkey.MqtFnName)
 	fnNamespace := input.String(flagkey.NamespaceFunction)

pkg/fission-cli/cmd/package/create.go

@@ -160,7 +160,11 @@ func CreatePackage(input cli.Input, client client.Interface, pkgName string, pkg
 	}
 
 	if len(pkgName) == 0 {
-		pkgName = strings.ToLower(uuid.NewV4().String())
+		id, err := uuid.NewV4()
+		if err != nil {
+			return nil, errors.Wrap(err, "error generating UUID")
+		}
+		pkgName = strings.ToLower(id.String())
 	}
 
 	pkg := &fv1.Package{

pkg/fission-cli/cmd/package/package.go

@@ -124,7 +124,11 @@ func CreateArchive(client client.Interface, input cli.Input, includeFiles []stri
 				return nil, err
 			}
 
-			file := filepath.Join(tmpDir, uuid.NewV4().String())
+			id, err := uuid.NewV4()
+			if err != nil {
+				return nil, err
+			}
+			file := filepath.Join(tmpDir, id.String())
 			err = utils.DownloadUrl(context.Background(), http.DefaultClient, fileURL, file)
 			if err != nil {
 				return nil, errors.Wrap(err, "error downloading file from the given URL")

pkg/fission-cli/cmd/package/util/util.go

@@ -107,7 +107,11 @@ func DownloadToTempFile(fileUrl string) (string, error) {
 		return "", errors.Wrapf(err, "error creating temp directory %v", tmpDir)
 	}
 
-	tmpFilename := uuid.NewV4().String()
+	id, err := uuid.NewV4()
+	if err != nil {
+		return "", errors.Wrapf(err, "error generating UUID")
+	}
+	tmpFilename := id.String()
 	destination := filepath.Join(tmpDir, tmpFilename)
 
 	err = WriteArchiveToFile(destination, reader)
@@ -135,7 +139,11 @@ func WriteArchiveToFile(fileName string, reader io.Reader) error {
 	if err != nil {
 		return err
 	}
-	tmpFileName := uuid.NewV4().String()
+	id, err := uuid.NewV4()
+	if err != nil {
+		return err
+	}
+	tmpFileName := id.String()
 
 	path := filepath.Join(tmpDir, tmpFileName+".tmp")
 	w, err := os.Create(path)

pkg/fission-cli/cmd/spec/init.go

@@ -67,7 +67,11 @@ func (opts *InitSubCommand) complete(input cli.Input) error {
 
 	deployID := input.String(flagkey.SpecDeployID)
 	if len(deployID) == 0 {
-		deployID = uuid.NewV4().String()
+		id, err := uuid.NewV4()
+		if err != nil {
+			return errors.Wrap(err, "error generating UUID")
+		}
+		deployID = id.String()
 	}
 
 	// Create spec dir

pkg/fission-cli/cmd/timetrigger/create.go

@@ -56,7 +56,11 @@ func (opts *CreateSubCommand) do(input cli.Input) error {
 func (opts *CreateSubCommand) complete(input cli.Input) error {
 	name := input.String(flagkey.TtName)
 	if len(name) == 0 {
-		name = uuid.NewV4().String()
+		id, err := uuid.NewV4()
+		if err != nil {
+			return err
+		}
+		name = id.String()
 	}
 
 	fnName := input.String(flagkey.TtFnName)