From e219804cde2e93a45025464c60d523cd444bf5d6 Mon Sep 17 00:00:00 2001 From: Soam Vasani Date: Fri, 11 Nov 2016 11:56:19 -0800 Subject: [PATCH] Fix segfault in defer statement A defer statement contained an access to a pointer that was set to nil before the deferred statement was run; remove it and just explicity run the statement. --- poolmgr/gp.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/poolmgr/gp.go b/poolmgr/gp.go index 9ce5f57d..801b29d2 100644 --- a/poolmgr/gp.go +++ b/poolmgr/gp.go @@ -251,9 +251,8 @@ func (gp *GenericPool) specializePod(metadata *fission.Metadata) (*v1.Pod, error maxRetries := 20 for i := 0; i < maxRetries; i++ { resp2, err := http.Post(specializeUrl, "text/plain", bytes.NewReader([]byte{})) - defer resp2.Body.Close() - if err == nil && resp2.StatusCode < 300 { + resp2.Body.Close() return pod, nil }