From dffb5cdf8ba7f49ae1abd6e1074b53db4ea674fe Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Fri, 17 Aug 2018 16:05:13 +0800 Subject: [PATCH] Fix CLI failed to setup port-forward caused by #712 (#867) --- fission/portforward/portforward.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fission/portforward/portforward.go b/fission/portforward/portforward.go index 8b6d60fe..0ac52bbf 100644 --- a/fission/portforward/portforward.go +++ b/fission/portforward/portforward.go @@ -132,7 +132,7 @@ func runPortForward(kubeConfig string, labelSelector string, localPort string, n namespaces := make(map[string][]*v1.Pod) // make a useful error message if there is more than one install - if len(podList.Items) > 1 { + if len(podList.Items) > 0 { for _, p := range podList.Items { if _, ok := namespaces[p.Namespace]; !ok { namespaces[p.Namespace] = []*v1.Pod{} @@ -146,6 +146,9 @@ func runPortForward(kubeConfig string, labelSelector string, localPort string, n } } + // there is at most one namespace in nsList, + // use index 0 to get from it directly. + ns = nsList[0] pods, ok := namespaces[ns] if !ok { log.Fatal(fmt.Sprintf("Error finding fission install within the given namespace %v, please check FISSION_NAMESPACE is set properly", ns))