From d7ac0ee17ae2efcd78bd4b79689237f43f18c8a8 Mon Sep 17 00:00:00 2001 From: Jacob Date: Thu, 20 May 2021 03:52:25 +0800 Subject: [PATCH] feat: Add image pull policy when create KEDA connector deployments (#1944) Co-authored-by: Vishal --- charts/fission-all/templates/deployment.yaml | 2 ++ charts/fission-core/templates/deployment.yaml | 2 ++ pkg/mqtrigger/scalermanager.go | 3 ++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/charts/fission-all/templates/deployment.yaml b/charts/fission-all/templates/deployment.yaml index 210ef183..b2c71567 100644 --- a/charts/fission-all/templates/deployment.yaml +++ b/charts/fission-all/templates/deployment.yaml @@ -1095,6 +1095,8 @@ spec: value: {{ .Values.traceSamplingRate | default "0.5" | quote }} - name: DEBUG_ENV value: {{ .Values.debugEnv | quote }} + - name: CONNECTOR_IMAGE_PULL_POLICY + value: "{{ .Values.pullPolicy }}" - name: KAFKA_IMAGE value: "{{ .Values.mqt_keda.connector_images.kafka.image }}:{{ .Values.mqt_keda.connector_images.kafka.tag }}" - name: RABBITMQ_IMAGE diff --git a/charts/fission-core/templates/deployment.yaml b/charts/fission-core/templates/deployment.yaml index fd5aa582..2a7286df 100644 --- a/charts/fission-core/templates/deployment.yaml +++ b/charts/fission-core/templates/deployment.yaml @@ -484,6 +484,8 @@ spec: value: {{ .Values.traceSamplingRate | default "0.5" | quote }} - name: DEBUG_ENV value: {{ .Values.debugEnv | quote }} + - name: CONNECTOR_IMAGE_PULL_POLICY + value: "{{ .Values.pullPolicy }}" - name: KAFKA_IMAGE value: "{{ .Values.mqt_keda.connector_images.kafka.image }}:{{ .Values.mqt_keda.connector_images.kafka.tag }}" - name: RABBITMQ_IMAGE diff --git a/pkg/mqtrigger/scalermanager.go b/pkg/mqtrigger/scalermanager.go index 429dcb01..d5c95668 100644 --- a/pkg/mqtrigger/scalermanager.go +++ b/pkg/mqtrigger/scalermanager.go @@ -393,6 +393,7 @@ func getDeploymentSpec(mqt *fv1.MessageQueueTrigger, routerURL string, kubeClien } imageName := fmt.Sprintf("%s_image", string(mqt.Spec.MessageQueueType)) image := os.Getenv(strings.ToUpper(imageName)) + imagePullPolicy := utils.GetImagePullPolicy(os.Getenv("CONNECTOR_IMAGE_PULL_POLICY")) blockOwnerDeletion := true return &appsv1.Deployment{ @@ -428,7 +429,7 @@ func getDeploymentSpec(mqt *fv1.MessageQueueTrigger, routerURL string, kubeClien { Name: mqt.ObjectMeta.Name, Image: image, - ImagePullPolicy: "Always", + ImagePullPolicy: imagePullPolicy, Env: envVars, }, },