From d524748b6d4aff07008ba6ad7a26331112d75e55 Mon Sep 17 00:00:00 2001 From: AetheWu Date: Wed, 11 May 2022 13:47:55 +0800 Subject: [PATCH] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20env=20update=20cmd=20add?= =?UTF-8?q?=20runtime-env=20flags=20(#2420)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pkg/fission-cli/cmd/environment/command.go | 2 +- pkg/fission-cli/cmd/environment/update.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/fission-cli/cmd/environment/command.go b/pkg/fission-cli/cmd/environment/command.go index feea1f0b..df19f13b 100644 --- a/pkg/fission-cli/cmd/environment/command.go +++ b/pkg/fission-cli/cmd/environment/command.go @@ -59,7 +59,7 @@ func Commands() *cobra.Command { Optional: []flag.Flag{flag.EnvImage, flag.EnvPoolsize, flag.EnvBuilderImage, flag.EnvBuildCmd, flag.EnvImagePullSecret, flag.RunTimeMinCPU, flag.RunTimeMaxCPU, flag.RunTimeMinMemory, flag.RunTimeMaxMemory, - flag.EnvTerminationGracePeriod, flag.EnvKeepArchive, + flag.EnvTerminationGracePeriod, flag.EnvKeepArchive, flag.EnvRuntime, flag.NamespaceEnvironment, flag.EnvExternalNetwork, flag.Labels, flag.Annotation}, }) diff --git a/pkg/fission-cli/cmd/environment/update.go b/pkg/fission-cli/cmd/environment/update.go index 8e05d09b..3d5b871c 100644 --- a/pkg/fission-cli/cmd/environment/update.go +++ b/pkg/fission-cli/cmd/environment/update.go @@ -163,6 +163,12 @@ func updateExistingEnvironmentWithCmd(env *fv1.Environment, input cli.Input) (*f env.Spec.Resources.Limits[v1.ResourceMemory] = memLimit } + if input.IsSet(flagkey.EnvRuntime) { + runtimeEnvParams := input.StringSlice(flagkey.EnvRuntime) + runtimeEnvList := util.GetEnvVarFromStringSlice(runtimeEnvParams) + env.Spec.Runtime.Container.Env = runtimeEnvList + } + limitCPU := env.Spec.Resources.Limits[v1.ResourceCPU] requestCPU := env.Spec.Resources.Requests[v1.ResourceCPU]