Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix poolmgr cache bug

Browse Source 
Poolmgr cache was useless because it was keying by *fission.Metadata
instead of the metadata itself.
This commit is contained in:
Soam Vasani
2016-11-04 23:05:29 -07:00
parent 094da5c69a
commit d512159cb3
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
poolmgr/api.go
+7 -7
View File
@@ -54,9 +54,9 @@ type API struct {
func MakeAPI(gpm *GenericPoolManager, controller *controllerclient.Client) *API { func MakeAPI(gpm *GenericPoolManager, controller *controllerclient.Client) *API {
return &API{ return &API{
poolMgr: gpm, poolMgr: gpm,
functionEnv: cache.MakeCache(), functionEnv: cache.MakeCache(0),
functionService: cache.MakeCache(), functionService: cache.MakeCache(time.Minute),
urlFuncSvc: cache.MakeCache(), urlFuncSvc: cache.MakeCache(time.Minute),
controller: controller, controller: controller,
} }
} }
@@ -90,7 +90,7 @@ func (api *API) getFunctionEnv(m *fission.Metadata) (*fission.Environment, error
var env *fission.Environment var env *fission.Environment
// Cached ? // Cached ?
result, err := api.functionEnv.Get(m) result, err := api.functionEnv.Get(*m)
if err == nil { if err == nil {
env = result.(*fission.Environment) env = result.(*fission.Environment)
return env, nil return env, nil
@@ -111,7 +111,7 @@ func (api *API) getFunctionEnv(m *fission.Metadata) (*fission.Environment, error
} }
// cache for future // cache for future
api.functionEnv.Set(m, env) api.functionEnv.Set(*m, env)
return env, nil return env, nil
} }
@@ -119,7 +119,7 @@ func (api *API) getFunctionEnv(m *fission.Metadata) (*fission.Environment, error
func (api *API) getServiceForFunction(m *fission.Metadata) (string, error) { func (api *API) getServiceForFunction(m *fission.Metadata) (string, error) {
// Check function -> svc map // Check function -> svc map
log.Printf("[%v] Checking for cached function service", m.Name) log.Printf("[%v] Checking for cached function service", m.Name)
result, err := api.functionService.Get(m) result, err := api.functionService.Get(*m)
if err == nil { if err == nil {
// Ok: return svc name // Ok: return svc name
svc := result.(*funcSvc) svc := result.(*funcSvc)
@@ -152,7 +152,7 @@ func (api *API) getServiceForFunction(m *fission.Metadata) (string, error) {
} }
// add to cache // add to cache
err = api.functionService.Set(m, funcSvc) err = api.functionService.Set(*m, funcSvc)
if err != nil { if err != nil {
// log and ignore error // log and ignore error
log.Printf("Error caching function service: %v", err) log.Printf("Error caching function service: %v", err)