Fix the namespace mismatch problem when deploying with a single YAML file (#1344)

If a user deploys fission in the namespace which is different from the one in the single YAML file generated by helm, fission components won't be able to talk to each other due to the wrong namespace appends after the service address.

This PR adds --namespace when generating the YAML file to prevent the mismatch problem.
This commit is contained in:
Ta-Ching Chen
2019-10-09 01:14:56 +08:00
committed by GitHub
parent e253d2a376
commit d358a29b17
6 changed files with 9 additions and 10 deletions
+1 -1
View File
@@ -205,7 +205,7 @@ func serveMetric(logger *zap.Logger) {
// StartExecutor Starts executor and the executor components such as Poolmgr,
// deploymgr and potential future executor types
func StartExecutor(logger *zap.Logger, fissionNamespace string, functionNamespace string, envBuilderNamespace string, port int) error {
func StartExecutor(logger *zap.Logger, functionNamespace string, envBuilderNamespace string, port int) error {
fissionClient, kubernetesClient, _, err := crd.MakeFissionClient()
err = fissionClient.WaitForCRDs()
+1 -1
View File
@@ -175,7 +175,7 @@ func TestExecutor(t *testing.T) {
// create poolmgr
port := 9999
err = StartExecutor(logger, fissionNs, functionNs, "fission-builder", port)
err = StartExecutor(logger, functionNs, "fission-builder", port)
if err != nil {
log.Panicf("failed to start poolmgr: %v", err)
}