Add tests for preupgradchecks and spec/archive CLI (#2874)

* Add tests for preupgradchecks
* Add spec tests
* Add package archive tests
* Wait for cleanup
* Fix test and coverage

---------

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

pkg/fission-cli/cmd/archive/delete.go

@@ -50,7 +50,7 @@ func (opts *DeleteSubCommand) do(input cli.Input) error {
 		return err
 	}
 
-	fmt.Printf("Deleted archive with id: %s", archiveID)
+	fmt.Printf("Deleted archive with id: %s\n", archiveID)
 
 	return nil
 }

pkg/fission-cli/cmd/archive/geturl.go

@@ -66,12 +66,11 @@ func (opts *GetURLSubCommand) do(input cli.Input) error {
 	storageType := resp.Header.Get("X-FISSION-STORAGETYPE")
 
 	if storageType == "local" {
-		storageSvc, err := util.GetSvcName(input.Context(), opts.Client().KubernetesClient, "fission-storage")
+		storagesvcURL, err := util.GetStorageURL(input.Context(), opts.Client())
 		if err != nil {
 			return err
 		}
-		storagesvcURL := "http://" + storageSvc
-		client := storagesvcClient.MakeClient(storagesvcURL)
+		client := storagesvcClient.MakeClient(storagesvcURL.String())
 		fmt.Printf("URL: %s", client.GetUrl(archiveID))
 	} else if storageType == "s3" {
 		storageBucket := resp.Header.Get("X-FISSION-BUCKET")

pkg/fission-cli/cmd/archive/upload.go

@@ -49,7 +49,6 @@ func (opts *UploadSubCommand) do(input cli.Input) error {
 		return err
 	}
 
-	fmt.Printf("File successfully uploaded with ID: %s ", archiveID)
-
+	fmt.Fprintf(input.Stdout(), "File successfully uploaded with ID: %s\n", archiveID)
 	return nil
 }

pkg/fission-cli/cmd/httptrigger/create.go

@@ -124,15 +124,6 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 
 	// For Specs, the spec validate checks for function reference
 	if input.Bool(flagkey.SpecSave) {
-
-		htTrigger, err := opts.Client().FissionClientSet.CoreV1().HTTPTriggers(m.Namespace).Get(input.Context(), m.Name, metav1.GetOptions{})
-		if err != nil && !kerrors.IsNotFound(err) {
-			return err
-		}
-		if htTrigger.Name != "" && htTrigger.Namespace != "" {
-			return errors.New("duplicate trigger exists, choose a different name or leave it empty for fission to auto-generate it")
-		}
-
 		specDir := util.GetSpecDir(input)
 		specIgnore := util.GetSpecIgnore(input)
 		fr, err := spec.ReadSpecs(specDir, specIgnore, false)

pkg/fission-cli/cmd/package/util/util.go

@@ -51,7 +51,6 @@ func UploadArchiveFile(ctx context.Context, client cmd.Client, fileName string)
 			return nil, err
 		}
 	} else {
-
 		storagesvcURL, err := util.GetStorageURL(ctx, client)
 		if err != nil {
 			return nil, errors.Wrapf(err, "error getting fission storage service URL")
@@ -105,12 +104,11 @@ func getArchiveURL(ctx context.Context, client cmd.Client, archiveID string, ser
 	storageType := resp.Header.Get("X-FISSION-STORAGETYPE")
 
 	if storageType == "local" {
-		storageSvc, err := util.GetSvcName(ctx, client.KubernetesClient, "fission-storage")
+		storagesvcURL, err := util.GetStorageURL(ctx, client)
 		if err != nil {
 			return "", err
 		}
-		storagesvcURL := "http://" + storageSvc
-		client := storageSvcClient.MakeClient(storagesvcURL)
+		client := storageSvcClient.MakeClient(storagesvcURL.String())
 		return client.GetUrl(archiveID), nil
 	} else if storageType == "s3" {
 		storageBucket := resp.Header.Get("X-FISSION-BUCKET")
@@ -166,23 +164,19 @@ func DownloadURL(fileUrl string) (io.ReadCloser, error) {
 
 func DownloadStrorageURL(ctx context.Context, client cmd.Client, fileUrl string) (io.ReadCloser, error) {
 	var resp *http.Response
-	storageSvc, err := util.GetSvcName(ctx, client.KubernetesClient, "fission-storage")
+	storagesvcURL, err := util.GetStorageURL(ctx, client)
 	if err != nil {
 		return nil, err
 	}
 
-	if strings.HasPrefix(fileUrl, "http://"+storageSvc+"/v1/archive?id=") {
+	if strings.HasPrefix(fileUrl, storagesvcURL.String()+"/v1/archive?id=") {
 		url, err := url.Parse(fileUrl)
 		if err != nil {
 			return nil, err
 		}
 		id := url.Query().Get("id")
-		storageAccessURL, err := util.GetStorageURL(ctx, client)
-		if err != nil {
-			return nil, err
-		}
 
-		client := storageSvcClient.MakeClient(storageAccessURL.String())
+		client := storageSvcClient.MakeClient(storagesvcURL.String())
 		resp, err = client.GetFile(ctx, id)
 		if err != nil {
 			return nil, err