From d16de59e9f68cab3e16b756fe975c36bf0fd254c Mon Sep 17 00:00:00 2001 From: Sanket Sudake Date: Fri, 9 Dec 2022 15:16:51 +0530 Subject: [PATCH] Pass prometheus dump path and port to analyzer script (#2665) Signed-off-by: Sanket Sudake Signed-off-by: Sanket Sudake --- hack/dump-analyzer | 7 ++++++- hack/dump-analyzer.md | 16 +++++++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hack/dump-analyzer b/hack/dump-analyzer index 1b29410d..742d3465 100755 --- a/hack/dump-analyzer +++ b/hack/dump-analyzer @@ -30,6 +30,7 @@ function prom_context() { if [ -z "$PROM_CONTEXT" ]; then exit_error "PROM_CONTEXT not set" fi + echo "Prometheus context: $PROM_CONTEXT" } function list_context() { @@ -113,7 +114,7 @@ function prometheus_run() { --config.file=$ETC_PROM/config_out/prometheus.env.yaml \ --storage.tsdb.path=${TSDB_PATH}/ \ --web.enable-lifecycle \ - --web.listen-address=127.0.0.1:9090 \ + --web.listen-address=127.0.0.1:${PROM_PORT:-9090} \ --web.route-prefix=/ \ --storage.tsdb.wal-compression \ --web.config.file=$ETC_PROM/web_config/web-config.yaml @@ -185,6 +186,10 @@ while getopts ${optstring} arg; do list_kind ;; p) + ARG_PROM_CONTEXT=$2 + if [ ! -z "$ARG_PROM_CONTEXT" ]; then + PROM_CONTEXT=$ARG_PROM_CONTEXT + fi prometheus_run ;; :) diff --git a/hack/dump-analyzer.md b/hack/dump-analyzer.md index f61bb039..be77d41f 100644 --- a/hack/dump-analyzer.md +++ b/hack/dump-analyzer.md @@ -127,7 +127,21 @@ kind v0.14.0 go1.18.2 linux/amd64 ## Prometheus with dump ```sh -$ export DUMP_CONTEXT=.dumps/3539792658/prom-dump-3539792658-v1.21.14 +$ export PROM_CONTEXT=.dumps/3539792658/prom-dump-3539792658-v1.21.14 $ ./hack/dump-analyzer -p # Visit localhost:9090 ``` + +To pass dump path directly without setting PROM_CONTEXT, + +```sh +$ ./hack/dump-analyzer -p .dumps/3539792658/prom-dump-3539792658-v1.21.14 +# Visit localhost:9090 +``` + +You can also run prometheus with multiple dumps, + +```sh +PROM_PORT=9091 ./hack/dump-analyzer -p .dumps/3539792658/prom-dump-3539792658-v1.21.14 +# Visit localhost:9091 +```