From ca1702c85bdbbef57d4839dbab4d86fe1a205c80 Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Fri, 30 Aug 2019 23:39:45 +0800 Subject: [PATCH] Fix unit tests failure (#1297) --- pkg/controller/api_test.go | 1 + pkg/controller/controller.go | 3 --- pkg/crd/crd_test.go | 1 + 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/controller/api_test.go b/pkg/controller/api_test.go index 5eccca204..c311f8520 100644 --- a/pkg/controller/api_test.go +++ b/pkg/controller/api_test.go @@ -205,6 +205,7 @@ func TestEnvironmentApi(t *testing.T) { Namespace: metav1.NamespaceDefault, }, Spec: fv1.EnvironmentSpec{ + Version: 1, Runtime: fv1.Runtime{ Image: "gcr.io/xyz", }, diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go index c3c8fb192..93ece2567 100644 --- a/pkg/controller/controller.go +++ b/pkg/controller/controller.go @@ -49,9 +49,6 @@ func Start(logger *zap.Logger, port int, unitTestFlag bool) { } defer cancel() - // openapi service - //go openAPI(cLogger) - api, err := MakeAPI(cLogger, featureStatus) if err != nil { cLogger.Fatal("failed to start controller", zap.Error(err)) diff --git a/pkg/crd/crd_test.go b/pkg/crd/crd_test.go index c3deb3ac8..e775c4821 100644 --- a/pkg/crd/crd_test.go +++ b/pkg/crd/crd_test.go @@ -147,6 +147,7 @@ func environmentTests(crdClient *rest.RESTClient) { Namespace: metav1.NamespaceDefault, }, Spec: fv1.EnvironmentSpec{ + Version: 1, Runtime: fv1.Runtime{ Image: "xxx", },