From c6beb29f5a984846dd45f116a718767aad376e48 Mon Sep 17 00:00:00 2001 From: elastic17 <44340390+elastic17@users.noreply.github.com> Date: Mon, 12 Aug 2024 21:41:56 +0800 Subject: [PATCH] Code cleanup from Fission CLI (#2983) Co-authored-by: yufu huang --- pkg/fission-cli/cmd/environment/create.go | 3 +-- pkg/fission-cli/cmd/environment/update.go | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/fission-cli/cmd/environment/create.go b/pkg/fission-cli/cmd/environment/create.go index e45d537e..2c35153f 100644 --- a/pkg/fission-cli/cmd/environment/create.go +++ b/pkg/fission-cli/cmd/environment/create.go @@ -132,8 +132,7 @@ func createEnvironmentFromCmd(input cli.Input) (*fv1.Environment, error) { pullSecret := input.String(flagkey.EnvImagePullSecret) envVersion := input.Int(flagkey.EnvVersion) - // Environment API interface version is not specified and - // builder image is empty, set default interface version + if envVersion == 0 { envVersion = 1 } diff --git a/pkg/fission-cli/cmd/environment/update.go b/pkg/fission-cli/cmd/environment/update.go index 5c1bbb6c..c95a60af 100644 --- a/pkg/fission-cli/cmd/environment/update.go +++ b/pkg/fission-cli/cmd/environment/update.go @@ -97,9 +97,6 @@ func (opts *UpdateSubCommand) run(input cli.Input) error { if err != nil { return errors.Wrap(err, "error updating environment") } - if err != nil { - return errors.Wrap(err, "error updating environment") - } fmt.Printf("environment '%v' updated\n", enew.ObjectMeta.Name) return nil