Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Add pathType to create networking/v1 ingress (#2164)

Browse Source 
* fix: Add pathType to create networking/v1 ingress

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

Co-authored-by: Sanket Sudake <sanketsudake@gmail.com>
This commit is contained in:
Jacob
2021-08-20 08:49:55 +05:30
committed by GitHub
co-authored by Sanket Sudake
parent 0c8d7c26c5
commit c51c6b7f7e
2 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/router/util/util.go
+3 -1
View File
@@ -55,6 +55,7 @@ func GetIngressSpec(namespace string, trigger *fv1.HTTPTrigger) *v1.Ingress {
} }
} }
var pathType v1.PathType = v1.PathTypeImplementationSpecific
ing := &v1.Ingress{ ing := &v1.Ingress{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Labels: GetDeployLabels(trigger), Labels: GetDeployLabels(trigger),
@@ -82,7 +83,8 @@ func GetIngressSpec(namespace string, trigger *fv1.HTTPTrigger) *v1.Ingress {
}, },
}, },
}, },
Path: path, Path: path,
PathType: &pathType,
}, },
}, },
}, },
pkg/router/util/util_test.go
+17 -8
View File
@@ -31,6 +31,7 @@ func TestGetIngressSpec(t *testing.T) {
ingressNS string ingressNS string
trigger *fv1.HTTPTrigger trigger *fv1.HTTPTrigger
} }
var pathType v1.PathType = v1.PathTypeImplementationSpecific
tests := []struct { tests := []struct {
name string name string
args args args args
@@ -84,7 +85,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },
@@ -145,7 +147,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },
@@ -204,7 +207,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },
@@ -263,7 +267,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/{bar}", Path: "/foo/{bar}",
PathType: &pathType,
}, },
}, },
}, },
@@ -322,7 +327,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/{bar}", Path: "/foo/{bar}",
PathType: &pathType,
}, },
}, },
}, },
@@ -382,7 +388,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },
@@ -441,7 +448,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },
@@ -512,7 +520,8 @@ func TestGetIngressSpec(t *testing.T) {
}, },
}, },
}, },
Path: "/foo/bar", Path: "/foo/bar",
PathType: &pathType,
}, },
}, },
}, },