Error when env name/image not provided (#98)

I also renamed image to envImg for consistency
This commit is contained in:
Laurent Crisci
2017-02-02 10:23:16 -08:00
committed by Soam Vasani
parent 7b58ef389d
commit c353e7f230
+25 -2
View File
@@ -30,7 +30,14 @@ func envCreate(c *cli.Context) error {
client := getClient(c.GlobalString("server")) client := getClient(c.GlobalString("server"))
envName := c.String("name") envName := c.String("name")
if len(envName) == 0 {
fatal("Need a name, use --name.")
}
envImg := c.String("image") envImg := c.String("image")
if len(envImg) == 0 {
fatal("Need an image, use --image.")
}
env := &fission.Environment{ env := &fission.Environment{
Metadata: fission.Metadata{ Metadata: fission.Metadata{
@@ -50,6 +57,10 @@ func envGet(c *cli.Context) error {
client := getClient(c.GlobalString("server")) client := getClient(c.GlobalString("server"))
envName := c.String("name") envName := c.String("name")
if len(envName) == 0 {
fatal("Need a name, use --name.")
}
m := &fission.Metadata{Name: envName} m := &fission.Metadata{Name: envName}
env, err := client.EnvironmentGet(m) env, err := client.EnvironmentGet(m)
checkErr(err, "get environment") checkErr(err, "get environment")
@@ -66,12 +77,20 @@ func envUpdate(c *cli.Context) error {
client := getClient(c.GlobalString("server")) client := getClient(c.GlobalString("server"))
envName := c.String("name") envName := c.String("name")
image := c.String("image") if len(envName) == 0 {
fatal("Need a name, use --name.")
}
envImg := c.String("image")
if len(envImg) == 0 {
fatal("Need an image, use --image.")
}
env := &fission.Environment{ env := &fission.Environment{
Metadata: fission.Metadata{ Metadata: fission.Metadata{
Name: envName, Name: envName,
}, },
RunContainerImageUrl: image, RunContainerImageUrl: envImg,
} }
_, err := client.EnvironmentUpdate(env) _, err := client.EnvironmentUpdate(env)
@@ -85,6 +104,10 @@ func envDelete(c *cli.Context) error {
client := getClient(c.GlobalString("server")) client := getClient(c.GlobalString("server"))
envName := c.String("name") envName := c.String("name")
if len(envName) == 0 {
fatal("Need a name , use --name.")
}
m := &fission.Metadata{Name: envName} m := &fission.Metadata{Name: envName}
err := client.EnvironmentDelete(m) err := client.EnvironmentDelete(m)
checkErr(err, "delete environment") checkErr(err, "delete environment")