From c192f49f93d3822dff6fa125b18d6d8ab82bc54d Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Fri, 3 Aug 2018 13:00:29 +0800 Subject: [PATCH] Do resources validation when validate spec files (#840) --- fission/spec.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fission/spec.go b/fission/spec.go index f08db8dbb..52c9e9662 100644 --- a/fission/spec.go +++ b/fission/spec.go @@ -286,6 +286,8 @@ func (fr *FissionResources) validate() error { archives[aname] = true } } + + result = multierror.Append(result, p.Validate()) } // error on unreferenced archives @@ -336,6 +338,8 @@ func (fr *FissionResources) validate() error { } else { packages[mapKey(pkgMeta)] = true } + + result = multierror.Append(result, f.Validate()) } // error on unreferenced packages @@ -356,24 +360,28 @@ func (fr *FissionResources) validate() error { if err != nil { result = multierror.Append(result, err) } + result = multierror.Append(result, t.Validate()) } for _, t := range fr.kubernetesWatchTriggers { err := fr.validateFunctionReference(functions, t.Kind, &t.Metadata, t.Spec.FunctionReference) if err != nil { result = multierror.Append(result, err) } + result = multierror.Append(result, t.Validate()) } for _, t := range fr.timeTriggers { err := fr.validateFunctionReference(functions, t.Kind, &t.Metadata, t.Spec.FunctionReference) if err != nil { result = multierror.Append(result, err) } + result = multierror.Append(result, t.Validate()) } for _, t := range fr.messageQueueTriggers { err := fr.validateFunctionReference(functions, t.Kind, &t.Metadata, t.Spec.FunctionReference) if err != nil { result = multierror.Append(result, err) } + result = multierror.Append(result, t.Validate()) } // we do not error on unreferenced functions (you can call a function through workflows,