Codebase cleanup & optimization (#1493)

Remove old v1 types that are no longer used and move fetcher structs to fetcher directory.

pkg/controller/functionApi.go

@@ -41,7 +41,6 @@ import (
 
 	fv1 "github.com/fission/fission/pkg/apis/fission.io/v1"
 	ferror "github.com/fission/fission/pkg/error"
-	"github.com/fission/fission/pkg/types"
 )
 
 func RegisterFunctionRoute(ws *restful.WebService) {
@@ -307,9 +306,9 @@ func (a *API) FunctionPodLogs(w http.ResponseWriter, r *http.Request) {
 
 	// Get function Pods first
 	selector := map[string]string{
-		types.FUNCTION_UID:          string(f.ObjectMeta.UID),
-		types.ENVIRONMENT_NAME:      f.Spec.Environment.Name,
-		types.ENVIRONMENT_NAMESPACE: f.Spec.Environment.Namespace,
+		fv1.FUNCTION_UID:          string(f.ObjectMeta.UID),
+		fv1.ENVIRONMENT_NAME:      f.Spec.Environment.Name,
+		fv1.ENVIRONMENT_NAMESPACE: f.Spec.Environment.Namespace,
 	}
 	podList, err := a.kubernetesClient.CoreV1().Pods(podNs).List(metav1.ListOptions{
 		LabelSelector: labels.Set(selector).AsSelector().String(),