Update staticcheck version and fix all warnings (#1381)

pkg/router/functionHandler.go

@@ -154,8 +154,7 @@ func (roundTripper RetryingRoundTripper) RoundTrip(req *http.Request) (*http.Res
 	roundTripper.addForwardedHostHeader(req)
 
 	// TODO: Keep? --> Needed for queries encoded in URL before they're stripped by the proxy
-	var originalUrl url.URL
-	originalUrl = *req.URL
+	originalUrl := *req.URL
 
 	// Iff this request needs to be recorded, we save the body
 	var postedBody string
@@ -245,7 +244,7 @@ func (roundTripper RetryingRoundTripper) RoundTrip(req *http.Request) (*http.Res
 						Body:          ioutil.NopCloser(bytes.NewBufferString(errMsg)),
 						ContentLength: int64(len(errMsg)),
 						Request:       req,
-						Header:        make(http.Header, 0),
+						Header:        make(http.Header),
 					}, nil
 				}
 				return nil, ferror.MakeError(http.StatusInternalServerError, err.Error())

pkg/router/functionRecorderMap.go

@@ -51,7 +51,7 @@ func (frmap *functionRecorderMap) lookup(function string) (*fv1.Recorder, error)
 }
 
 func (frmap *functionRecorderMap) assign(function string, recorder *fv1.Recorder) {
-	err, _ := frmap.cache.Set(function, recorder)
+	_, err := frmap.cache.Set(function, recorder)
 	if err != nil {
 		if e, ok := err.(ferror.Error); ok && e.Code == ferror.ErrorNameExists {
 			return

pkg/router/functionReferenceResolver.go

@@ -20,11 +20,8 @@ import (
 	"fmt"
 	"time"
 
+	"github.com/pkg/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/fields"
-	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/watch"
-	"k8s.io/client-go/rest"
 	k8sCache "k8s.io/client-go/tools/cache"
 
 	fv1 "github.com/fission/fission/pkg/apis/fission.io/v1"
@@ -37,9 +34,7 @@ type (
 	functionReferenceResolver struct {
 		// FunctionReference -> function metadata
 		refCache *cache.Cache
-
-		stopCh chan struct{}
-		store  k8sCache.Store
+		store    k8sCache.Store
 	}
 
 	resolveResultType int
@@ -81,21 +76,6 @@ func makeFunctionReferenceResolver(store k8sCache.Store) *functionReferenceResol
 	return frr
 }
 
-func makeK8SCache(crdClient *rest.RESTClient) (k8sCache.Store, k8sCache.Controller) {
-	watchlist := k8sCache.NewListWatchFromClient(crdClient, "functions", metav1.NamespaceDefault, fields.Everything())
-	listWatch := &k8sCache.ListWatch{
-		ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
-			return watchlist.List(options)
-		},
-		WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
-			return watchlist.Watch(options)
-		},
-	}
-	resyncPeriod := 30 * time.Second
-	return k8sCache.NewInformer(listWatch, &fv1.Function{}, resyncPeriod,
-		k8sCache.ResourceEventHandlerFuncs{})
-}
-
 // resolve translates a trigger's function reference to a resolveResult.
 func (frr *functionReferenceResolver) resolve(trigger fv1.HTTPTrigger) (*resolveResult, error) {
 	nfr := namespacedTriggerReference{
@@ -128,7 +108,7 @@ func (frr *functionReferenceResolver) resolve(trigger fv1.HTTPTrigger) (*resolve
 		}
 
 	default:
-		return nil, fmt.Errorf("Unrecognized function reference type %v", trigger.Spec.FunctionReference.Type)
+		return nil, errors.Errorf("unrecognized function reference type %v", trigger.Spec.FunctionReference.Type)
 	}
 
 	// cache resolve result
@@ -150,7 +130,7 @@ func (frr *functionReferenceResolver) resolveByName(namespace, name string) (*re
 		return nil, err
 	}
 	if !isExist {
-		return nil, fmt.Errorf("function %v does not exist", name)
+		return nil, errors.Errorf("function %v does not exist", name)
 	}
 
 	f := obj.(*fv1.Function)
@@ -167,7 +147,7 @@ func (frr *functionReferenceResolver) resolveByName(namespace, name string) (*re
 
 func (frr *functionReferenceResolver) resolveByFunctionWeights(namespace string, fr *fv1.FunctionReference) (*resolveResult, error) {
 
-	functionMetadataMap := make(map[string]*metav1.ObjectMeta, 0)
+	functionMetadataMap := make(map[string]*metav1.ObjectMeta)
 	fnWtDistrList := make([]FunctionWeightDistribution, 0)
 	sumPrefix := 0
 

pkg/router/functionServiceMap.go

@@ -68,7 +68,7 @@ func (fmap *functionServiceMap) lookup(f *metav1.ObjectMeta) (*url.URL, error) {
 
 func (fmap *functionServiceMap) assign(f *metav1.ObjectMeta, serviceUrl *url.URL) {
 	mk := keyFromMetadata(f)
-	err, old := fmap.cache.Set(*mk, serviceUrl)
+	old, err := fmap.cache.Set(*mk, serviceUrl)
 	if err != nil {
 		if *serviceUrl == *(old.(*url.URL)) {
 			return

pkg/router/ingress.go

@@ -72,12 +72,12 @@ func deleteIngress(logger *zap.Logger, trigger *fv1.HTTPTrigger, kubeClient *kub
 
 func updateIngress(logger *zap.Logger, oldT *fv1.HTTPTrigger, newT *fv1.HTTPTrigger, kubeClient *kubernetes.Clientset) {
 
-	if oldT.Spec.CreateIngress == false && newT.Spec.CreateIngress == true {
+	if !oldT.Spec.CreateIngress && newT.Spec.CreateIngress {
 		createIngress(logger, newT, kubeClient)
 		return
 	}
 
-	if newT.Spec.CreateIngress == false && oldT.Spec.CreateIngress == true {
+	if !newT.Spec.CreateIngress && oldT.Spec.CreateIngress {
 		deleteIngress(logger, oldT, kubeClient)
 		return
 	}

pkg/router/mutablemux_test.go

@@ -47,7 +47,7 @@ func spamServer(quit chan bool) {
 	for {
 		select {
 		case <-quit:
-			break
+			return
 		default:
 			i = i + 1
 			resp, err := http.Get("http://localhost:3333")

pkg/router/recorderController.go

@@ -113,7 +113,7 @@ func (rs *RecorderSet) disableRecorder(r *fv1.Recorder) {
 }
 
 func (rs *RecorderSet) updateRecorder(old *fv1.Recorder, newer *fv1.Recorder) {
-	if newer.Spec.Enabled == true {
+	if newer.Spec.Enabled {
 		rs.newRecorder(newer) // TODO: Test this
 	} else {
 		rs.disableRecorder(old)

pkg/router/triggerRecorderMap.go

@@ -50,7 +50,7 @@ func (trmap *triggerRecorderMap) lookup(trigger string) (*fv1.Recorder, error) {
 }
 
 func (trmap *triggerRecorderMap) assign(trigger string, recorder *fv1.Recorder) {
-	err, _ := trmap.cache.Set(trigger, recorder)
+	_, err := trmap.cache.Set(trigger, recorder)
 	if err != nil {
 		if e, ok := err.(ferror.Error); ok && e.Code == ferror.ErrorNameExists {
 			return