Update staticcheck version and fix all warnings (#1381)

pkg/executor/newdeploy/newdeploy.go

@@ -143,10 +143,6 @@ func (deploy *NewDeploy) setupRBACObjs(deployNamespace string, fn *fv1.Function)
 	return nil
 }
 
-func (deploy *NewDeploy) getDeployment(ns, name string) (*appsv1.Deployment, error) {
-	return deploy.kubernetesClient.AppsV1().Deployments(ns).Get(name, metav1.GetOptions{})
-}
-
 func (deploy *NewDeploy) updateDeployment(deployment *appsv1.Deployment, ns string) error {
 	_, err := deploy.kubernetesClient.AppsV1().Deployments(ns).Update(deployment)
 	return err

pkg/executor/newdeploy/newdeploymgr.go

@@ -61,7 +61,6 @@ type (
 		runtimeImagePullPolicy apiv1.PullPolicy
 		namespace              string
 		useIstio               bool
-		collectorEndpoint      string
 
 		fsCache *fscache.FunctionServiceCache // cache funcSvc's by function, address and pod name
 
@@ -523,7 +522,7 @@ func (deploy *NewDeploy) updateFunction(oldFn *fv1.Function, newFn *fv1.Function
 		}
 	}
 
-	if deployChanged == true {
+	if deployChanged {
 		env, err := deploy.fissionClient.Environments(newFn.Spec.Environment.Namespace).
 			Get(newFn.Spec.Environment.Name)
 		if err != nil {
@@ -624,20 +623,6 @@ func (deploy *NewDeploy) getDeployLabels(fnMeta metav1.ObjectMeta, envMeta metav
 	}
 }
 
-// updateKubeObjRefRV update the resource version of kubeObjectRef with
-// given kind and return error if failed to find the reference.
-func (deploy *NewDeploy) updateKubeObjRefRV(fsvc *fscache.FuncSvc, objKind string, rv string) error {
-	kubeObjs := fsvc.KubernetesObjects
-	for i, obj := range kubeObjs {
-		if obj.Kind == objKind {
-			kubeObjs[i].ResourceVersion = rv
-			return nil
-		}
-	}
-	fsvc.KubernetesObjects = kubeObjs
-	return fmt.Errorf("error finding kubernetes object reference with kind: %v", objKind)
-}
-
 // updateStatus is a function which updates status of update.
 // Current implementation only logs messages, in future it will update function status
 func (deploy *NewDeploy) updateStatus(fn *fv1.Function, err error, message string) {