Update staticcheck version and fix all warnings (#1381)

pkg/executor/fscache/functionServiceCache.go

@@ -68,15 +68,13 @@ type (
 		requestChannel chan *fscRequest
 	}
 	fscRequest struct {
-		requestType       fscRequestType
-		address           string
-		kubernetesObjects []apiv1.ObjectReference
-		age               time.Duration
-		responseChannel   chan *fscResponse
+		requestType     fscRequestType
+		address         string
+		age             time.Duration
+		responseChannel chan *fscResponse
 	}
 	fscResponse struct {
 		objects []*FuncSvc
-		deleted bool
 		error
 	}
 )
@@ -180,7 +178,7 @@ func (fsc *FunctionServiceCache) GetByFunctionUID(uid types.UID) (*FuncSvc, erro
 }
 
 func (fsc *FunctionServiceCache) Add(fsvc FuncSvc) (*FuncSvc, error) {
-	err, existing := fsc.byFunction.Set(crd.CacheKey(fsvc.Function), &fsvc)
+	existing, err := fsc.byFunction.Set(crd.CacheKey(fsvc.Function), &fsvc)
 	if err != nil {
 		if IsNameExistError(err) {
 			f := existing.(*FuncSvc)
@@ -199,7 +197,7 @@ func (fsc *FunctionServiceCache) Add(fsvc FuncSvc) (*FuncSvc, error) {
 
 	// Add to byAddress cache. Ignore NameExists errors
 	// because of multiple-specialization. See issue #331.
-	err, _ = fsc.byAddress.Set(fsvc.Address, *fsvc.Function)
+	_, err = fsc.byAddress.Set(fsvc.Address, *fsvc.Function)
 	if err != nil {
 		if IsNameExistError(err) {
 			err = nil
@@ -211,7 +209,7 @@ func (fsc *FunctionServiceCache) Add(fsvc FuncSvc) (*FuncSvc, error) {
 
 	// Add to byFunctionUID cache. Ignore NameExists errors
 	// because of multiple-specialization. See issue #331.
-	err, _ = fsc.byFunctionUID.Set(fsvc.Function.UID, *fsvc.Function)
+	_, err = fsc.byFunctionUID.Set(fsvc.Function.UID, *fsvc.Function)
 	if err != nil {
 		if IsNameExistError(err) {
 			err = nil
@@ -257,7 +255,7 @@ func (fsc *FunctionServiceCache) DeleteEntry(fsvc *FuncSvc) {
 	fsc.byFunctionUID.Delete(fsvc.Function.UID)
 
 	fsc.observeFuncRunningTime(fsvc.Function.Name, string(fsvc.Function.UID), fsvc.Atime.Sub(fsvc.Ctime).Seconds())
-	fsc.observeFuncAliveTime(fsvc.Function.Name, string(fsvc.Function.UID), time.Now().Sub(fsvc.Ctime).Seconds())
+	fsc.observeFuncAliveTime(fsvc.Function.Name, string(fsvc.Function.UID), time.Since(fsvc.Ctime).Seconds())
 	fsc.setFuncAlive(fsvc.Function.Name, string(fsvc.Function.UID), false)
 }
 

pkg/executor/fscache/functionServiceCache_test.go

@@ -74,12 +74,12 @@ func TestFunctionServiceCache(t *testing.T) {
 		log.Panicf("Failed to add fsvc: %v", err)
 	}
 
-	f, err := fsc.GetByFunction(fsvc.Function)
+	_, err = fsc.GetByFunction(fsvc.Function)
 	if err != nil {
 		fsc.Log()
 		log.Panicf("Failed to get fsvc: %v", err)
 	}
-	f, err = fsc.GetByFunctionUID(fsvc.Function.UID)
+	f, err := fsc.GetByFunctionUID(fsvc.Function.UID)
 	if err != nil {
 		fsc.Log()
 		log.Panicf("Failed to get fsvc by function uid: %v", err)

pkg/executor/fscache/metrics.go

@@ -5,8 +5,6 @@ import (
 )
 
 var (
-	metricAddr = ":8080"
-
 	// funcname: the function's name
 	// funcuid: the function's version id
 	coldStarts = prometheus.NewCounterVec(