Update staticcheck version and fix all warnings (#1381)

pkg/controller/client/client.go

@@ -20,13 +20,13 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io/ioutil"
 	"net/http"
 	"strings"
 	"time"
 
+	"github.com/pkg/errors"
 	"golang.org/x/net/context/ctxhttp"
 
 	ferror "github.com/fission/fission/pkg/error"
@@ -58,9 +58,9 @@ func (c *Client) delete(relativeUrl string) error {
 	if resp.StatusCode != 200 {
 		body, err := ioutil.ReadAll(resp.Body)
 		if err != nil {
-			return errors.New("Delete failed")
+			return errors.Wrap(err, "error deleting")
 		} else {
-			return errors.New("Delete failed: " + string(body))
+			return errors.Errorf("failed to delete: %v", string(body))
 		}
 	}
 

pkg/controller/client/core.go

@@ -22,6 +22,8 @@ import (
 	"io/ioutil"
 	"net/http"
 
+	"github.com/pkg/errors"
+
 	apiv1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -84,7 +86,7 @@ func (c *Client) GetSvcURL(label string) (string, error) {
 	}
 
 	if resp == nil {
-		return "", fmt.Errorf("Failed to find service for given label: %v", label)
+		return "", errors.Errorf("failed to find service for given label: %v", label)
 	}
 
 	defer resp.Body.Close()