Update staticcheck version and fix all warnings (#1381)

2019-11-05 18:09:12 +08:00
parent 93d4b88d84
commit b9a5588ca9
43 changed files with 122 additions and 219 deletions
@@ -443,6 +443,9 @@ func (canaryCfgMgr *canaryConfigMgr) rollback(canaryConfig *fv1.CanaryConfig, tr
 	functionWeights[canaryConfig.Spec.OldFunction] = 100

 	err := canaryCfgMgr.updateHttpTriggerWithRetries(trigger.Metadata.Name, trigger.Metadata.Namespace, functionWeights)
+	if err != nil {
+		return err
+	}

 	err = canaryCfgMgr.updateCanaryConfigStatusWithRetries(canaryConfig.Metadata.Name, canaryConfig.Metadata.Namespace,
 		types.CanaryConfigStatusFailed)