Update staticcheck version and fix all warnings (#1381)

pkg/canaryconfigmgr/canaryConfigCache.go

@@ -68,7 +68,7 @@ func (cancelFuncMap *canaryConfigCancelFuncMap) lookup(f *metav1.ObjectMeta) (*C
 
 func (cancelFuncMap *canaryConfigCancelFuncMap) assign(f *metav1.ObjectMeta, value *CanaryProcessingInfo) error {
 	mk := keyFromMetadata(f)
-	err, _ := cancelFuncMap.cache.Set(mk, value)
+	_, err := cancelFuncMap.cache.Set(mk, value)
 	return err
 }
 

pkg/canaryconfigmgr/canaryConfigMgr.go

@@ -443,6 +443,9 @@ func (canaryCfgMgr *canaryConfigMgr) rollback(canaryConfig *fv1.CanaryConfig, tr
 	functionWeights[canaryConfig.Spec.OldFunction] = 100
 
 	err := canaryCfgMgr.updateHttpTriggerWithRetries(trigger.Metadata.Name, trigger.Metadata.Namespace, functionWeights)
+	if err != nil {
+		return err
+	}
 
 	err = canaryCfgMgr.updateCanaryConfigStatusWithRetries(canaryConfig.Metadata.Name, canaryConfig.Metadata.Namespace,
 		types.CanaryConfigStatusFailed)