From b95e317a20a15dd960b4f71c2b5ccd03b22327a7 Mon Sep 17 00:00:00 2001 From: soharab-ic <156293296+soharab-ic@users.noreply.github.com> Date: Tue, 28 May 2024 19:47:44 +0530 Subject: [PATCH] fix: Router failed to create ingress resource in `fission` namespace (#2951) * Router failed to create ingress resource in `fission` namespace ``` fission-router has access to create ingress in default namespace. fission is creating ingress in namespace where fission is installed. updated the helm chart to give fission-router access to create ingress in release namespace. ``` * Add a todo comment for modifying router's permissions --------- Signed-off-by: Md Soharab Ansari --- charts/fission-all/templates/_fission-kubernetes-roles.tpl | 2 ++ charts/fission-all/templates/router/role-kubernetes.yaml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/fission-all/templates/_fission-kubernetes-roles.tpl b/charts/fission-all/templates/_fission-kubernetes-roles.tpl index 6afebde3..4c3a6f4b 100644 --- a/charts/fission-all/templates/_fission-kubernetes-roles.tpl +++ b/charts/fission-all/templates/_fission-kubernetes-roles.tpl @@ -354,6 +354,8 @@ rules: # TODO: Kept for future in case preupgrade needs any permissions in the future rules: [] {{- end }} +# TODO: Currently, router needs ingress related permissions only. +# In future if router's permissions are modified then check the configured namespace. {{- define "router-kuberules" }} rules: - apiGroups: diff --git a/charts/fission-all/templates/router/role-kubernetes.yaml b/charts/fission-all/templates/router/role-kubernetes.yaml index 27a38951..5dfeb42f 100644 --- a/charts/fission-all/templates/router/role-kubernetes.yaml +++ b/charts/fission-all/templates/router/role-kubernetes.yaml @@ -1,4 +1,4 @@ -{{- include "kubernetes-role-generator" (merge (dict "namespace" .Values.defaultNamespace "component" "router") .) }} +{{- include "kubernetes-role-generator" (merge (dict "namespace" .Release.Namespace "component" "router") .) }} {{- if gt (len .Values.additionalFissionNamespaces) 0 }} {{- range $namespace := $.Values.additionalFissionNamespaces }}