From 3f02ccaf3403d930fc620ec2796a8724bed00175 Mon Sep 17 00:00:00 2001 From: Soam Vasani Date: Tue, 17 Jan 2017 18:42:54 -0800 Subject: [PATCH 1/2] Bug fix for handling a route's HTTP method in router --- router/httpTriggers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/router/httpTriggers.go b/router/httpTriggers.go index 4663ba9f..22a89334 100644 --- a/router/httpTriggers.go +++ b/router/httpTriggers.go @@ -73,7 +73,7 @@ func (ts *HTTPTriggerSet) getRouter() *mux.Router { Function: m, poolmgr: ts.poolmgr, } - muxRouter.HandleFunc(trigger.UrlPattern, fh.handler) + muxRouter.HandleFunc(trigger.UrlPattern, fh.handler).Methods(trigger.Method) } // Internal triggers for (the latest version of) each function From 3ed5e772cf8d104238ec083432151f391e12476e Mon Sep 17 00:00:00 2001 From: Soam Vasani Date: Tue, 17 Jan 2017 22:06:02 -0800 Subject: [PATCH 2/2] Update test to include method --- router/router_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/router/router_test.go b/router/router_test.go index da58120c..59b5c7db 100644 --- a/router/router_test.go +++ b/router/router_test.go @@ -35,7 +35,7 @@ func TestRouter(t *testing.T) { triggers := makeHTTPTriggerSet(fmap, nil, nil) triggerUrl := "/foo" - triggers.triggers = append(triggers.triggers, fission.HTTPTrigger{UrlPattern: triggerUrl, Function: *fn}) + triggers.triggers = append(triggers.triggers, fission.HTTPTrigger{UrlPattern: triggerUrl, Function: *fn, Method: "GET"}) port := 4242 go serve(port, triggers)