Enable promlinter and enhance exposed metrics. (#2550)

* Enable promlinter
* Rename archives metric and update dashboard, linter

Co-authored-by: shaunak_deshmukh <shaunak@infracloud.io>

.golangci.yaml

@@ -14,6 +14,7 @@ linters:
     - misspell
     - nakedret
     - unconvert
+    - promlinter
     # Enable in future
     # - bodyclose
     # - dogsled

charts/fission-all/dashboards/.lint

@@ -9,5 +9,3 @@ exclusions:
     reason: "Most panels dont need to be filtered by instance"
   panel-units-rule:
     reason: "Some panels are using the 'number' unit which throws a linting error."
-  target-counter-agg-rule:
-    reason: "disabled for fission_archives_total. This metric should be not have total due to naming conventions as its a gauge, not a counter"

charts/fission-all/dashboards/fission-admin-dashboard.json

@@ -879,7 +879,7 @@
             "uid": "${datasource}"
           },
           "editorMode": "code",
-          "expr": "fission_archives_total",
+          "expr": "fission_archives",
           "legendFormat": "Namespace: {{namespace}} Pod: {{pod}}",
           "range": true,
           "refId": "A"
@@ -970,7 +970,7 @@
             "uid": "${datasource}"
           },
           "editorMode": "code",
-          "expr": "rate(fission_archives_total[$__rate_interval])",
+          "expr": "rate(fission_archives[$__rate_interval])",
           "legendFormat": "Namespace: {{namespace}} Pod: {{pod}}",
           "range": true,
           "refId": "A"

pkg/storagesvc/metrics.go

@@ -9,7 +9,7 @@ var (
 	functionLabels = []string{}
 	totalArchives  = promauto.NewGaugeVec(
 		prometheus.GaugeOpts{
-			Name: "fission_archives_total",
+			Name: "fission_archives",
 			Help: "Number of archives stored",
 		},
 		functionLabels,