From b06ff625e0691714e41c755d362b1ee594b3bfea Mon Sep 17 00:00:00 2001 From: Ankit Chawla Date: Fri, 11 Feb 2022 09:00:47 +0530 Subject: [PATCH] Fix validation for secret & configmap reference with function (#2349) --- pkg/controller/client/v1/misc.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkg/controller/client/v1/misc.go b/pkg/controller/client/v1/misc.go index 96c7dd8f..d422018b 100644 --- a/pkg/controller/client/v1/misc.go +++ b/pkg/controller/client/v1/misc.go @@ -23,7 +23,9 @@ import ( "net/http" "github.com/pkg/errors" + k8serrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime/schema" "github.com/fission/fission/pkg/controller/client/rest" "github.com/fission/fission/pkg/fission-cli/console" @@ -62,6 +64,9 @@ func (c *Misc) SecretExists(m *metav1.ObjectMeta) error { return err } defer resp.Body.Close() + if resp.StatusCode >= 400 { + return k8serrors.NewNotFound(schema.GroupResource{Group: "", Resource: "secret"}, m.Name) + } return nil } @@ -74,6 +79,9 @@ func (c *Misc) ConfigMapExists(m *metav1.ObjectMeta) error { return err } defer resp.Body.Close() + if resp.StatusCode >= 400 { + return k8serrors.NewNotFound(schema.GroupResource{Group: "", Resource: "configmap"}, m.Name) + } return nil }