From a8fc7a70293a1727e0e80189357caba1fa735ce0 Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Thu, 27 Jul 2017 02:43:23 +0800 Subject: [PATCH] Fix nats trigger replies message to non-existing resptopic (#260) --- mqtrigger/messageQueue/nats.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mqtrigger/messageQueue/nats.go b/mqtrigger/messageQueue/nats.go index 1ca0af41..39f6185f 100644 --- a/mqtrigger/messageQueue/nats.go +++ b/mqtrigger/messageQueue/nats.go @@ -128,9 +128,12 @@ func msgHandler(nats *Nats, trigger fission.MessageQueueTrigger) func(*ns.Msg) { if err != nil { log.Warningf("Failed to ack message: %v", err) } - err = nats.nsConn.Publish(trigger.ResponseTopic, body) - if err != nil { - log.Warningf("Failed to publish message to topic %s: %v", trigger.ResponseTopic, err) + + if len(trigger.ResponseTopic) > 0 { + err = nats.nsConn.Publish(trigger.ResponseTopic, body) + if err != nil { + log.Warningf("Failed to publish message to topic %s: %v", trigger.ResponseTopic, err) + } } } }