From 9c41ab7905c01f36e33dc59dfeac2d8f02781497 Mon Sep 17 00:00:00 2001 From: xiekeyang Date: Thu, 7 Jun 2018 15:45:32 +0800 Subject: [PATCH] ArchiveLiteralSizeLimit: Use Constant Instead Hard Code (#731) This use constant to instead hard code for ArchiveLiteralSizeLimit. That ensure if the limitation value is changed in cli, the controller server can follow it. Otherwise, the condition will return error, and make error HTTP response. Later, we should delete it in fission-cli, and make it configurable it chart, to work in fission- servers only. --- controller/packageApi.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/packageApi.go b/controller/packageApi.go index 797bc25e3..2656bf7c2 100644 --- a/controller/packageApi.go +++ b/controller/packageApi.go @@ -63,12 +63,12 @@ func (a *API) PackageApiCreate(w http.ResponseWriter, r *http.Request) { } // Ensure size limits - if len(f.Spec.Source.Literal) > 256*1024 { + if len(f.Spec.Source.Literal) > int(fission.ArchiveLiteralSizeLimit) { err := fission.MakeError(fission.ErrorInvalidArgument, "Package literal larger than 256K") a.respondWithError(w, err) return } - if len(f.Spec.Deployment.Literal) > 256*1024 { + if len(f.Spec.Deployment.Literal) > int(fission.ArchiveLiteralSizeLimit) { err := fission.MakeError(fission.ErrorInvalidArgument, "Package literal larger than 256K") a.respondWithError(w, err) return