diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index da0a68d2..25a052b8 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -18,7 +18,7 @@ on: workflow_dispatch: env: - GOLANGCI_LINT_VERSION: v1.57.0 + GOLANGCI_LINT_VERSION: v1.61.0 GOLANGCI_LINT_TIMEOUT: 5m jobs: diff --git a/go.mod b/go.mod index cfb96bbb..24e848ae 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/fission/fission -go 1.22.2 +go 1.23.1 require ( dario.cat/mergo v1.0.0 diff --git a/pkg/executor/executortype/poolmgr/gp.go b/pkg/executor/executortype/poolmgr/gp.go index a846fc23..49112292 100644 --- a/pkg/executor/executortype/poolmgr/gp.go +++ b/pkg/executor/executortype/poolmgr/gp.go @@ -426,7 +426,7 @@ func (gp *GenericPool) specializePod(ctx context.Context, pod *apiv1.Pod, fn *fv zap.String("configmap_namespace", cm.Namespace), zap.String("function_name", fn.ObjectMeta.Name), zap.String("function_namespace", gp.fnNamespace)) - return fmt.Errorf(fmt.Sprintf("configmap %s must be in same namespace as function namespace", cm.Name)) + return fmt.Errorf("configmap %s must be in same namespace as function namespace", cm.Name) } else { return err } @@ -441,7 +441,7 @@ func (gp *GenericPool) specializePod(ctx context.Context, pod *apiv1.Pod, fn *fv zap.String("secret_namespace", sec.Namespace), zap.String("function_name", fn.ObjectMeta.Name), zap.String("function_namespace", gp.fnNamespace)) - return fmt.Errorf(fmt.Sprintf("secret %s must be in same namespace as function namespace", sec.Name)) + return fmt.Errorf("secret %s must be in same namespace as function namespace", sec.Name) } else { return err } diff --git a/pkg/mqtrigger/messageQueue/kafka/consumer.go b/pkg/mqtrigger/messageQueue/kafka/consumer.go index b684c8bc..920c5db5 100644 --- a/pkg/mqtrigger/messageQueue/kafka/consumer.go +++ b/pkg/mqtrigger/messageQueue/kafka/consumer.go @@ -200,7 +200,7 @@ func (ch *MqtConsumerGroupHandler) kafkaMsgHandler(msg *sarama.ConsumerMessage) errorString := fmt.Sprintf("request exceed retries: %v", ch.trigger.Spec.MaxRetries) errorHeaders := generateErrorHeaders(errorString) errorHandler(ch.logger, ch.trigger, ch.producer, ch.fnUrl, - fmt.Errorf(errorString), errorHeaders) + errors.New(errorString), errorHeaders) return } defer resp.Body.Close() @@ -215,7 +215,7 @@ func (ch *MqtConsumerGroupHandler) kafkaMsgHandler(msg *sarama.ConsumerMessage) errorString := "request body error: " + string(body) errorHeaders := generateErrorHeaders(errorString) errorHandler(ch.logger, ch.trigger, ch.producer, ch.fnUrl, - errors.Wrapf(err, errorString), errorHeaders) + errors.Wrap(err, errorString), errorHeaders) return } if resp.StatusCode != 200 {