From 971a314d63e33f74da13a7b17ee72dcf4d254341 Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Mon, 15 Jul 2019 21:01:32 +0800 Subject: [PATCH] Fix fetcher client doesn't handle error properly (#1238) --- pkg/fetcher/client/client.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/fetcher/client/client.go b/pkg/fetcher/client/client.go index 81fba94a..df354cae 100644 --- a/pkg/fetcher/client/client.go +++ b/pkg/fetcher/client/client.go @@ -5,13 +5,12 @@ import ( "context" "encoding/json" "io/ioutil" - - "go.uber.org/zap" - "net/http" "strings" "time" + "go.uber.org/zap" + "go.opencensus.io/plugin/ochttp" "golang.org/x/net/context/ctxhttp" @@ -61,6 +60,9 @@ func (c *Client) Fetch(ctx context.Context, fr *types.FunctionFetchRequest) erro func (c *Client) Upload(ctx context.Context, fr *types.ArchiveUploadRequest) (*types.ArchiveUploadResponse, error) { body, err := sendRequest(c.logger, ctx, c.httpClient, fr, c.getUploadUrl()) + if err != nil { + return nil, err + } uploadResp := types.ArchiveUploadResponse{} err = json.Unmarshal(body, &uploadResp)