Add static code analysis to CI test (#1197)

This commit is contained in:
Ta-Ching Chen
2019-06-02 14:29:38 +08:00
committed by GitHub
parent 1562cba420
commit 93d4f2c77a
23 changed files with 130 additions and 146 deletions
+4 -1
View File
@@ -403,6 +403,9 @@ func pkgDelete(c *cli.Context) error {
util.CheckErr(err, "find package")
fnList, err := getFunctionsByPackage(client, pkgName, pkgNamespace)
if err != nil {
return err
}
if !force && len(fnList) > 0 {
log.Fatal("Package is used by at least one function, use -f to force delete")
@@ -680,8 +683,8 @@ func writeArchiveToFile(fileName string, reader io.Reader) error {
// and write it to temp file for further usage
func downloadToTempFile(fileUrl string) string {
reader, err := downloadURL(fileUrl)
defer reader.Close()
util.CheckErr(err, fmt.Sprintf("download from url: %v", fileUrl))
defer reader.Close()
tmpDir, err := utils.GetTempDir()
util.CheckErr(err, "create temp directory")