Add static code analysis to CI test (#1197)

pkg/buildermgr/envwatcher.go

@@ -87,7 +87,6 @@ type (
 		fetcherConfig          *fetcherConfig.Config
 		builderImagePullPolicy apiv1.PullPolicy
 		useIstio               bool
-		collectorEndpoint      string
 	}
 )
 
@@ -389,40 +388,6 @@ func (envw *environmentWatcher) deleteBuilderDeploymentByName(name, namespace st
 	return nil
 }
 
-func (envw *environmentWatcher) deleteBuilderService(sel map[string]string, ns string) error {
-	svcList, err := envw.getBuilderServiceList(sel, ns)
-	if err != nil {
-		return err
-	}
-	for _, svc := range svcList {
-		envw.logger.Info("removing builder service", zap.String("service_name", svc.ObjectMeta.Name))
-		err = envw.kubernetesClient.CoreV1().
-			Services(ns).
-			Delete(svc.ObjectMeta.Name, &delOpt)
-		if err != nil {
-			return errors.Wrap(err, "error deleting builder service")
-		}
-	}
-	return nil
-}
-
-func (envw *environmentWatcher) deleteBuilderDeployment(sel map[string]string, ns string) error {
-	deployList, err := envw.getBuilderDeploymentList(sel, ns)
-	if err != nil {
-		return err
-	}
-	for _, deploy := range deployList {
-		envw.logger.Info("removing builder deployment", zap.String("deployment_name", deploy.ObjectMeta.Name))
-		err = envw.kubernetesClient.ExtensionsV1beta1().
-			Deployments(ns).
-			Delete(deploy.ObjectMeta.Name, &delOpt)
-		if err != nil {
-			return errors.Wrap(err, "error deleteing builder deployment")
-		}
-	}
-	return nil
-}
-
 func (envw *environmentWatcher) getBuilderServiceList(sel map[string]string, ns string) ([]apiv1.Service, error) {
 	svcList, err := envw.kubernetesClient.CoreV1().Services(ns).List(
 		metav1.ListOptions{

pkg/buildermgr/pkgwatcher.go

@@ -227,8 +227,6 @@ func (pkgw *packageWatcher) build(buildCache *cache.Cache, srcpkg *fv1.Package)
 
 	pkgw.logger.Error("max retries exceeded in building source package, timeout due to environment builder not ready",
 		zap.String("package", fmt.Sprintf("%s.%s", pkg.Metadata.Name, pkg.Metadata.Namespace)))
-
-	return
 }
 
 func (pkgw *packageWatcher) watchPackages(fissionClient *crd.FissionClient,